Improved pull request "Files Changed" experience feedback #163932
Replies: 3280 comments 1367 replies
|
I would like to be able to scroll through the Pull Request while the comment modal is open. Reason: When a comment is outdated, we need to look at the current version to check if it actually addresses the comment. I really love this feature! THANK YOU!!! |
|
Update: I just found out that it appears when there's enough space (1280px width). Here's the updated feedback. I'd like to see the branch name in the sticky header at all times so that I can easily copy it when I'm reviewing a PR. I wrote the following before thoroughly experimenting. I'd like to see the branch name when the sticky header is shown (i.e., when you've scrolled to the bottom). The reason is that when I'm reviewing a long PR and want to checkout the branch to continue reviewing it locally, I have to go back all the way up to see or copy the branch name and then go back to where I left off. |
|
I find the comment indicators in the sidebar really useful. It might also be useful to have them in the "diff file header." It's very useful when you've marked a file as "viewed" because you can see how many comments it has as you're scrolling without having to expand it. |
This is really cool. Is it also possible to seamlessly toggle hiding white spaces? If that's achievable without doing a refresh would be amazing. |
|
This is so much better, I might go back from reviewing with the VSCode extension now 🚀 I love the new alerts panel, unfortunately it looks like pressing Maybe we could have some grouping or clustering in the alerts panel in the future. |
|
I would love to see the file tree sorted alphabetically with folders on top, then files. It is quite jarring to have changed files in the middle of folders when viewing the file tree currently. Example of current state Example of desired state This would mirror how the majority of developers view the code in their IDE |
|
Hi, I would like to play around with this, but I'm not seeing the opt-in mentioned in
Am I missing something? |
|
It doesn't always seem to remember if hide whitespace was turned on. |
|
It looks like 'suggest a change' has been removed? Why? It's an extremely useful feature to be able to suggest a line change that the PR owner can quickly merge into their changes |
|
Scrolling is torched with this on. It just auto scrolls to random spots on the diff and down to the bottom of the page on conversations view. I thought it was a browser bug but its happening across the main 3 and different mice too. I turned this off and the file preview feature and its working fine now. |
|
Looking through a PR really needs keyboard shortcuts. if I have a PR with 50+ files changed. So I asked claude to put together a small chrome extension. so can you please add something like this to the new experience
|
|
When reviewing the changes for a Draft PR, I would like to be able to Mark it Ready from that screen instead of having to go back to the overview to click the button. My process:
|
|
Performance is super slow, especially when typing review comments when there are more than a few files changes or lots of lines changed in a PR |
|
Add a way to approve/add a block/add suggestions w/o having to go to the Files Changed tab. Many times the changes are already known/reviewed so providing that action from the front-page would save time and clicks, especially on subsequent visits to the same PR. Am I missing an easier way to approve a PR from the front-page/tab? |
|
I'd like an option for side-by-side diffs only on files with additions AND deletions, showing a unified diff for files with only one or the other. The side-by-side is a waste when there aren't both. |
|
submit review is buried in files changed and working team is having a hard time finding it |
|
From a PR, I click on a commit SHA and I now see a new "commit details in the scope of a PR" page (/pull/:id/changes/:sha). That page does not list the releases the commit has been tagged in. I need to click on the commit SHA again from that page to get to ye olde /commit/:sha page, and there I can see the releases. Would be handy to see the same detail in the first page. |
|
has GitHub ui designers completely forgot mobile devices when creating the new experience or not |
























Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
About the new experience
This updated experience focuses on performance, accessibility, and user productivity. Read more in the changelog.
Tip
If you are not already using the new experience, click the ✨Try the new experience in the upper-right corner of the classic "Files changed" page. You can easily switch back from the Preview menu.
✨ What's new
If you are coming from the classic experience, the new experience should feel familiar but adds some significant improvements:
✨ Updates
See what's been fixed and improved since the launch of the public preview:
🟡 Limitations
As of the initial public preview release, there are some temporary limitations that will be addressed over time:
While our previous experience had hard limits on large PRs, this new experience is being built to scale. That said, we’re increasing our limits incrementally. To start with, our additional current limitations are:
How you can help
Thanks for helping us build a better review experience—we read every comment!
All reactions