Skip to content

Qt: Re-enable Load button to browse for file - #11807

Merged
hrydgard merged 3 commits into
hrydgard:masterfrom
unknownbrackets:qt-browse
Feb 17, 2019
Merged

hrydgard merged 3 commits into
hrydgard:masterfrom
unknownbrackets:qt-browse

Conversation

@unknownbrackets

@unknownbrackets unknownbrackets commented Feb 17, 2019 •

Copy link
Copy Markdown
Collaborator

This makes it work the same as Windows, and also cleans up the "Browse..." button which was still crashing.

Fixes the browse part of #11721, and #11808 fixes the flicker so this fixes #11721.

-[Unknown]

@unknownbrackets unknownbrackets added this to the v1.8.0 milestone Feb 17, 2019
@hrydgard

Copy link
Copy Markdown
Owner

Yeah, this is the right way. Sorry for my laziness before....

@hrydgard
hrydgard merged commit f955cc0 into hrydgard:master Feb 17, 2019
@unknownbrackets
unknownbrackets deleted the qt-browse branch February 17, 2019 17:18
Comment thread Qt/QtMain.cpp
NativeMessageReceived("browse_folderSelect", fileName.toStdString().c_str());
}
} else {
return QWidget::event(e);

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Darn it, didn't even notice there were tabs and spaces in this file... sigh.

-[Unknown]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mac OS (Qt build) crashes when clicked Load...

2 participants