Repository navigation
Added new option "Copy Float (32 bit)" to Windows Debugger UI - #17203
Merged
Merged
Conversation
hrydgard
approved these changes
Mar 28, 2023
hrydgard
left a comment
Owner
There was a problem hiding this comment.
I'd probably have just used snprintf, but this is fine.
Collaborator
Author
I really didn't like the fact that floats have multiple string representations and with snprintf you have to make a buffer of known size beforehand. I had no idea how to do that safely, so I just decided to go with something more high-level. std::to_string didn't work as it kept turning very small floats to 0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example behavior: