Skip to content

Added new option "Copy Float (32 bit)" to Windows Debugger UI - #17203

Merged
hrydgard merged 1 commit into
hrydgard:masterfrom
Nemoumbra:remote-api-floats
Mar 28, 2023
Merged

hrydgard merged 1 commit into
hrydgard:masterfrom
Nemoumbra:remote-api-floats

Conversation

@Nemoumbra

Copy link
Copy Markdown
Collaborator

image
Example behavior:
image

@hrydgard hrydgard left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd probably have just used snprintf, but this is fine.

@hrydgard
hrydgard merged commit 6148040 into hrydgard:master Mar 28, 2023
@Nemoumbra

Copy link
Copy Markdown
Collaborator Author

I'd probably have just used snprintf, but this is fine.

I really didn't like the fact that floats have multiple string representations and with snprintf you have to make a buffer of known size beforehand. I had no idea how to do that safely, so I just decided to go with something more high-level. std::to_string didn't work as it kept turning very small floats to 0.

@Nemoumbra
Nemoumbra deleted the remote-api-floats branch March 28, 2023 13:32
@hrydgard hrydgard added this to the v1.15.0 milestone Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants