Repository navigation
GPU: Always update size when shrinking framebuffers - #17314
Merged
Merged
Conversation
Previously, we only updated size when we didn't need to recreate. This would sometimes cause it to recreate over and over, hurting perf.
hrydgard
approved these changes
Apr 20, 2023
hrydgard
enabled auto-merge
April 20, 2023 07:12
Owner
|
I changed "Should help" to "Fixes", because it does. Also tried a couple of usual suspects, not seeing issues. Logically I think this should be fine. |
hrydgard
disabled auto-merge
April 20, 2023 07:31
fengjixuchui
added a commit
to fengjixuchui/ppsspp
that referenced
this pull request
Apr 20, 2023
Merge pull request hrydgard#17314 from unknownbrackets/framebuf-shrink
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we only updated size when we didn't need to recreate. This would sometimes cause it to recreate over and over, hurting perf.
I think it's just a bug that we don't do this essentially only for framebuffers that are only rendered using throughmode and resize down after 5 frames. It's probably uncommon enough we just haven't seen it.
Fixes #16915.
-[Unknown]