Skip to content

Domain classes should be traits #450

Open

Description

@dcsobral

Github feature flags sometimes add fields to objects. While having the domain case classes as final is good, they should be implementations instead of being used directly in the type signature of the algebras. That way, one can extend an algebra to return more data without adding a new method.

And while the contravariant nature of parameters prevent us from doing the same for data sent to github, it would still be helpful to be able to extend those traits as a guideline.

Activity

  1. dcsobral commented on Apr 10, 2020

    @dcsobral
    ContributorAuthor

    Note that my motive is to make the tagless final design achieve its goals. This is not an abstract issue for me, as I run into this very problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions