Skip to content

style: use theme tokens for avatar and name input in onboarding (#1656) - #1663

Open
Prakhar1808 wants to merge 1 commit into
AOSSIE-Org:devfrom
Prakhar1808:fix/onboarding-avatar-light-theme
Open

Prakhar1808 wants to merge 1 commit into
AOSSIE-Org:devfrom
Prakhar1808:fix/onboarding-avatar-light-theme

Conversation

@Prakhar1808

@Prakhar1808 Prakhar1808 commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Addressed Issues:

Fixes #1656

Screenshots/Recordings:

after the fix
image

Check one of the checkboxes below:

  • This PR does not contain AI-generated code at all.
  • This PR contains AI-generated code. I have read the AI Usage Policy and this PR complies with this policy. I have tested the code locally and I am responsible for it.

I have used the following AI models and tools: gemini 3.8 Flash

Checklist

  • My PR addresses a single issue, fixes a single bug or makes a single improvement.
  • My code follows the project's code style and conventions
  • If applicable, I have made corresponding changes or additions to the documentation
  • If applicable, I have made corresponding changes or additions to tests
  • My changes generate no new warnings or errors
  • I have joined the Discord server and I will share a link to this PR with the project maintainers there
  • I have read the Contribution Guidelines
  • Once I submit my PR, CodeRabbit AI will automatically review it and I will address CodeRabbit's comments.
  • I have filled this PR template completely and carefully, and I understand that my PR may be closed without review otherwise.

Summary by CodeRabbit

  • Style
    • Updated the onboarding avatar and name panel, avatar preview placeholder, name label, and name input to use theme-based background, border, foreground, and muted text colors.
    • The name input now explicitly uses the theme’s foreground color.

@Prakhar1808 Prakhar1808 changed the title fix: use theme tokens for avatar and name input in onboarding (#1656) style: use theme tokens for avatar and name input in onboarding (#1656) Oct 26, 2026
@github-actions github-actions Bot added bug Something isn't working enhancement New feature or request possible-duplicate Potential semantic duplicate (upstream comparison) labels Oct 26, 2026
@coderabbitai

coderabbitai Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Walkthrough

The onboarding avatar and name panel now use theme-based background, foreground, border, and placeholder colors instead of fixed neutral colors.

Changes

Onboarding theme colors

Layer / File(s) Summary
Apply theme colors
frontend/src/components/OnboardingSteps/AvatarSelectionStep.tsx
The avatar-and-name row, empty avatar preview, name label, and name input now use theme-based colors. The input also applies the theme foreground color to entered text.

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix · Severity of issue fixed: Medium

Possibly related issues

  • AOSSIE-Org/PictoPy#1656: The theme-based colors replace the hardcoded colors described in the Light-theme onboarding issue.

Suggested labels: TypeScript/JavaScript

Suggested reviewers: takitxt

Merge Risk: Minimal · up to a8125

No actionable issue is identified; the change is mergeable after normal checks.

Pre-merge checks: Passed 4
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names the main change: onboarding avatar and name input now use theme tokens instead of fixed colors. The raw summary confirms the edits in AvatarSelectionStep.tsx replace fixed neutral colo…
Linked Issues check Passed Issue #1656 requires theme-compatible colors for the Light-theme onboarding name and avatar controls. The PR replaces fixed neutral colors with theme tokens for the panel, avatar preview, label, place…
Out of Scope Changes check Passed The reported changes are limited to theme color and input text styling in AvatarSelectionStep.tsx. Each change supports the fix for issue #1656. No unrelated change is identified.
Full details: Title check

Explanation

The title names the main change: onboarding avatar and name input now use theme tokens instead of fixed colors. The raw summary confirms the edits in AvatarSelectionStep.tsx replace fixed neutral colors with theme-based background, border, foreground, and muted text classes, and the linked issue #1656 describes the Light-theme contrast problem this fixes. The title follows conventional commit style and is specific enough for a teammate scanning history.

Full details: Linked Issues check

Explanation

Issue #1656 requires theme-compatible colors for the Light-theme onboarding name and avatar controls. The PR replaces fixed neutral colors with theme tokens for the panel, avatar preview, label, placeholder, border, and input text. These changes address the dark preview background, low-contrast label and placeholder, and low-visibility typed text. The issue states no automated test requirement.

Finishing Touches
Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Tip

🎯 Customize your risk assessments

Guide how CodeRabbit assesses merge risk and security architecture risk. Highlight sensitive changes and explain your security boundaries using Merge Risk Instructions and Security Risk Instructions in your review settings. Security architecture risk assessments require the Advanced plan or above.

✅ Automatic approvals, with your rules

Let CodeRabbit approve pull requests once required threads are resolved, pre-merge checks pass, and your risk limits are met. Enable Automatic approvals in review settings, with overrides for teams or file paths.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

A rabbit checks the name field's hue,
The avatar preview brightens too.
Muted borders blend with the theme,
Text stays clear across the screen.
Hops of color, soft and light,
Make onboarding look just right.

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.
Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 4b0e996 and a8125cf.

Files selected for processing: 1
  • frontend/src/components/OnboardingSteps/AvatarSelectionStep.tsx
Files skipped from review as they are similar to previous changes: 1
  • frontend/src/components/OnboardingSteps/AvatarSelectionStep.tsx

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

⚠️ This PR has merge conflicts.

Please resolve the merge conflicts before review.

Your PR will only be reviewed by a maintainer after all conflicts have been resolved.

📺 Watch this video to understand why conflicts occur and how to resolve them:
https://www.youtube.com/watch?v=Sqsz1-o7nXk

@Prakhar1808
Prakhar1808 force-pushed the fix/onboarding-avatar-light-theme branch from 4b0e996 to a8125cf Compare November 3, 2026 18:25

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request possible-duplicate Potential semantic duplicate (upstream comparison)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: PROD: v1.3.0-beta First-launch onboarding displays hardcoded black box for name/avatar input in Light theme

1 participant