Skip to content

fix: stop trimming passwords in Edit Album dialog - #1690

Open
ManyaJain111 wants to merge 1 commit into
AOSSIE-Org:devfrom
ManyaJain111:fix/edit-album-password-trim-dev
Open

ManyaJain111 wants to merge 1 commit into
AOSSIE-Org:devfrom
ManyaJain111:fix/edit-album-password-trim-dev

Conversation

@ManyaJain111

@ManyaJain111 ManyaJain111 commented Nov 4, 2026 •

Copy link
Copy Markdown

Addressed Issues:

Fixes #1637

Additional Notes:

EditAlbumDialog called .trim() on current_password and password before sending them. Create Album and the unlock dialog send the password exactly as typed, so for any password with a leading or trailing space, the password Edit Album sent never matched the stored one. The album could be opened but never edited ("The current password is incorrect"). Locking an album from Edit with pass also saved it as pass.

This PR sends both values unchanged. .trim() is still used for the empty checks, so blank or spaces-only passwords are rejected as before, and an empty "new password" field is still not sent.

Tested locally:

  • Locked album created with secret ,Edit Album with secret saves
  • Edit Album with secret (no space) is rejected
  • Spaces-only current password shows the "required" validation error

AI Usage Disclosure:

  • This PR does not contain AI-generated code at all.
  • This PR contains AI-generated code. I have read the AI Usage Policy and this PR complies with this policy. I have tested the code locally and I am responsible for it.

Checklist

  • My PR addresses a single issue, fixes a single bug or makes a single improvement.
  • My code follows the project's code style and conventions
  • If applicable, I have made corresponding changes or additions to the documentation
  • If applicable, I have made corresponding changes or additions to tests
  • My changes generate no new warnings or errors
  • I have joined the Discord server and I will share a link to this PR with the project maintainers there
  • I have read the Contribution Guidelines
  • Once I submit my PR, CodeRabbit AI will automatically review it and I will address CodeRabbit's comments.
  • I have filled this PR template completely and carefully, and I understand that my PR may be closed without review otherwise.

@github-actions github-actions Bot added backend bug Something isn't working labels Nov 4, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG:Edit Album strips spaces from the password so albums with a leading/trailing space in the password can't be edited

1 participant