Repository navigation
fix: stop trimming passwords in Edit Album dialog - #1690
Open
ManyaJain111 wants to merge 1 commit into
Open
ManyaJain111 wants to merge 1 commit into
ManyaJain111 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressed Issues:
Fixes #1637
Additional Notes:
EditAlbumDialogcalled.trim()oncurrent_passwordandpasswordbefore sending them. Create Album and the unlock dialog send the password exactly as typed, so for any password with a leading or trailing space, the password Edit Album sent never matched the stored one. The album could be opened but never edited ("The current password is incorrect"). Locking an album from Edit withpassalso saved it aspass.This PR sends both values unchanged.
.trim()is still used for the empty checks, so blank or spaces-only passwords are rejected as before, and an empty "new password" field is still not sent.Tested locally:
secret,Edit Album withsecretsavessecret(no space) is rejectedAI Usage Disclosure:
Checklist