Repository navigation
docs: add SamMethnani as a contributor for doc - #185
Merged
Merged
Conversation
Merged
mmabrouk
approved these changes
Jul 31, 2023
mmabrouk
added a commit
that referenced
this pull request
Sep 9, 2026
* fix(frontend): stop the Use API drawer render loop with two variants The variant-mode "How to use API" drawer kept a variant id and a revision id in state and reconciled them with three effects that each wrote what another read. With more than one variant the reconciliation had no fixed point: the drawer alternated between the two variants forever, and the first click on a language tab turned the loop synchronous and froze the tab with React #185. Make the revision the only selection state and derive the variant from it. The variant now comes from the selected revision entity, which already carries workflow_variant_id, so no list has to arrive before the drawer knows which variant it is showing. One effect remains, and it writes only while nothing is selected, so it runs at most once. Fixes #6708 * fix(frontend): keep the drawer's revision selection stable and recoverable Two defects Codex found in the first pass of the fix. The prop effect and the fallback effect could both see an empty selection in one pass, so the fallback overwrote a revision the prop had just supplied. The fallback now writes through a functional update that keeps whatever is there. A revision id that resolves to nothing, a deleted revision behind a shared link, left the drawer spinning for ever. Read the revision query so pending is told apart from unresolvable, and fall back to the first variant's latest revision when the requested one cannot be resolved. Also read the thin revision refs for the variant instead of resolving every revision entity, and accept the variant_slug alias the schema allows.
pull Bot
pushed a commit
to bhardwajRahul/agenta
that referenced
this pull request
Sep 14, 2026
… scrollWidth Resizing the configuration pane in /m could crash the page with React error Agenta-AI#185 ("Maximum update depth exceeded"). The tab strip decided whether the New session (+) overflows from `scrollWidth`, but whether to un-pin it from layout offsets. The chips are motion layout items: while the strip resizes, their layout animation holds them on a translate that `scrollWidth` counts as overflow and offsets do not. The two rules could each be satisfied in turn, so the (+) moved out of the scroller, the chips re-projected, the next measure moved it back, and the flips chained synchronously until React gave up. The throw surfaced inside the (+)'s tooltip trigger ref, which is why the stack pointed at Radix compose-refs. Both decisions, and the edge fade, now read the same transform-free content width. The hysteresis that was always intended holds: the pinned (+) sits outside the scroller, so `clientWidth` is already net of it. The regression test mounts a strip that fits, then delivers a resize while `scrollWidth` is inflated the way an in-flight translate inflates it; on the old code it reproduces the exact error. Fixes Agenta-AI#6742
1 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds @SamMethnani as a contributor for doc.
This was requested by mmabrouk in this comment
[skip ci]