Skip to content

#411 | Feature: Centralized Error Handling - #437

Merged
mmabrouk merged 6 commits into
Agenta-AI:mainfrom
MohammedMaaz:feature/411-centralized-error-handling-in-webapp
Aug 31, 2023
Merged

mmabrouk merged 6 commits into
Agenta-AI:mainfrom
MohammedMaaz:feature/411-centralized-error-handling-in-webapp

Conversation

@MohammedMaaz

@MohammedMaaz MohammedMaaz commented Aug 23, 2023 •

Copy link
Copy Markdown
Contributor
  • global error handler improved
  • centralized API error handling through axios interceptor
  • Catch React errors through ErrorBoundary
  • Refactoring

Resolves #411

@MohammedMaaz
MohammedMaaz requested review from aakrem and mmabrouk and removed request for mmabrouk August 23, 2023 22:16

@mmabrouk mmabrouk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @MohammedMaaz !
Can you please 1) solve the conflicts (I checked them out, they should be trivial) and 2) make sure it works in the ee version. I noticed that you have modified the Sidebar.tsx, I think a PR there that modifies it would be needed.

I will then be happy to approve and merge :)

@MohammedMaaz

Copy link
Copy Markdown
Contributor Author

Thanks a lot @MohammedMaaz ! Can you please 1) solve the conflicts (I checked them out, they should be trivial) and 2) make sure it works in the ee version. I noticed that you have modified the Sidebar.tsx, I think a PR there that modifies it would be needed.

I will then be happy to approve and merge :)

Done

PR for ee version: https://github.com/Agenta-AI/agenta_ee/pull/31

@mmabrouk mmabrouk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @MohammedMaaz !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Centralized error handling

2 participants