[panshularora]

Summary

Fixes two SDK unit tests that currently pass without exercising what they claim to check (follow-up from #5651 review / #5662).

1. Vacuous resolver test (test_a_bare_tool_name_string_is_ignored_too)

coerce_tool_configs([\"read\"]) returns a pydantic ToolConfigParseResult, not a sequence of tool configs. Passing the parse result into ToolResolver().resolve() meant iteration never saw the coerced BuiltinToolConfig, so the empty-spec assertion could pass for the wrong reason.

Change: assert the parse result contains a single BuiltinToolConfig, then pass parsed.tool_configs into resolve().

2. Substring-only JSON check (test_no_json_example_writes_a_builtin_tool_entry)

The old check looked for the literal substring "type": "builtin", so whitespace variants like "type":"builtin" could slip through.

Change: parse each fenced JSON block and recursively reject any object with type == "builtin".

Test plan

• Targeted test logic updated as described in (test) Built-ins SDK tests: vacuous coerce_tool_configs resolver test and substring-only JSON example check #5662
• CI unit tests for sdks/python/oss/tests/pytest/unit/agents/

Closes #5662

[vercel]

@panshularora is attempting to deploy a commit to the agenta projects Team on Vercel.

A member of the Team first needs to authorize it.

[CLAassistant]

All committers have signed the CLA.

[coderabbitai]

📝 Walkthrough

Summary by CodeRabbit

• Tests
  • Expanded validation for nested built-in tool entries in JSON examples, including fenced JSON with varying whitespace.
  • Strengthened coverage for built-in tool configuration resolution and confirmed these tools are ignored without producing tool specifications.

Walkthrough

The tests now parse fenced JSON to detect nested builtin tool entries and validate coerced builtin configurations before resolver execution.

Changes

Builtin tool validation

Layer / File(s)	Summary
Recursive JSON builtin detection sdks/python/oss/tests/pytest/unit/agents/test_agenta_builtins_reference_files.py	The test parses fenced JSON, accepts flexible whitespace, requires a JSON example, and recursively detects objects with type set to "builtin".
Coerced configuration resolver test sdks/python/oss/tests/pytest/unit/agents/tools/test_resolver.py	The test validates the BuiltinToolConfig returned by coerce_tool_configs before passing configurations to ToolResolver.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related issues

• Issue 5662 — The changes address resolver coercion and recursive JSON validation for builtin tools.

Possibly related PRs

• Agenta-AI/agenta#5680 — This PR modifies the same tests for builtin-tool detection and resolver coercion.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 33.33% which is insufficient. The required threshold is 60.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title clearly identifies the fix to vacuous built-in SDK tests.
Description check	✅ Passed	The description directly explains both test fixes and their validation changes.

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d270915a-4c73-493d-8499-822c0a897b73

📥 Commits

Reviewing files that changed from the base of the PR and between 3db504c and b7c1e5b.

📒 Files selected for processing (2)

• sdks/python/oss/tests/pytest/unit/agents/test_agenta_builtins_reference_files.py
• sdks/python/oss/tests/pytest/unit/agents/tools/test_resolver.py

[mmabrouk]

@all-contributors please add @panshularora for tests

[mmabrouk]

Thanks @panshularora for the tests !

[allcontributors]

@mmabrouk

I've put up a pull request to add @panshularora! 🎉