Skip to content

[test] Re-enable the Use API acceptance test after the drawer loop fix - #6713

Merged
mmabrouk merged 1 commit into
release/v0.115.3from
unquarantine-use-api-6708
Sep 9, 2026
Merged

mmabrouk merged 1 commit into
release/v0.115.3from
unquarantine-use-api-6708

Conversation

@mmabrouk

@mmabrouk mmabrouk commented Sep 9, 2026

Copy link
Copy Markdown
Member

Reverts the quarantine from #6709. The freeze it hid was fixed by #6711 (root cause in #6708). The acceptance test passed three times in a row on the fixed branch (5.2 s, 3.4 s, 3.2 s).

Test-only change: the test.fixme in web/oss/tests/playwright/acceptance/use-api/index.ts becomes test again.

@vercel

vercel Bot commented Sep 9, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
agenta-documentation Ready Ready Preview Sep 9, 2026 1:07am UTC

Request Review

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Mahmoud Mabrouk seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@coderabbitai

coderabbitai Bot commented Sep 9, 2026 •

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Advanced

Run ID: 3a46734b-9d84-4ff5-bbcf-50f514473fc1

📥 Commits

Reviewing files that changed from the base of the PR and between 7f4ec82 and a5626d1.

📒 Files selected for processing (1)
  • web/oss/tests/playwright/acceptance/use-api/index.ts

Included review availability: Your plan provides up to 8 included reviews per hour; 4 remain after this review.


📝 Summary

Summary by CodeRabbit

  • Tests
    • Re-enabled an acceptance test for the TypeScript API snippet variant.
    • The test now runs as part of the active test suite instead of being skipped.

Walkthrough

The change activates the variant TypeScript snippet acceptance test for Fetch Prompt/Config and Invoke LLM.

Changes

useApi acceptance test activation

Layer / File(s) Summary
Activate variant snippet test
web/oss/tests/playwright/acceptance/use-api/index.ts
The test changes from test.fixme to test and now runs normally.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to a5626

This change re-enables coverage for the variant TypeScript snippets shown in the deployment drawer. It does not change product behavior, and no merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies the test change and the reason for it. It matches the primary change: re-enabling the Use API acceptance test after the drawer loop fix.
Description check ✅ Passed The description accurately explains the quarantine reversal, the related fixes, and the specific test-only change from test.fixme to test.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch unquarantine-use-api-6708

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mmabrouk

mmabrouk commented Sep 9, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Sep 9, 2026 •

Copy link
Copy Markdown
Contributor
⚠️ Action not completed

Already reviewed the last commit. Use @coderabbitai full review to rerun a review of the entire changeset.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@github-actions

github-actions Bot commented Sep 9, 2026 •

Copy link
Copy Markdown
Contributor

Railway Preview Environment

Status Destroyed (PR closed)

Updated at 2026-09-09T01:18:58.592Z

@mmabrouk
mmabrouk merged commit ffc455b into release/v0.115.3 Sep 9, 2026
46 of 47 checks passed

This branch was successfully deployed

1 active deployment
Preview — a5626d1f Deployed Sep 9, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants