Repository navigation
[feat] Discover and expand playground files - #7346
Merged
mmabrouk merged 2 commits intoOct 5, 2026
Merged
Conversation
Contributor
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (13)
💤 Files with no reviewable changes (2)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 3 remain after this review. 📝 SummarySummary by CodeRabbit
WalkthroughThe change adds shared files-pane controls and transient expansion state. Mobile and OSS chat layouts use that state to expand Files and adjust other panes. Storage headers can also render a files toggle when given a scope. ChangesFiles Pane Expansion
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
actor User
participant DriveHeader
participant SessionFilesPane
participant AgentChatPanel
participant useFilesPaneLayout
participant RightPanelSplit
User->>DriveHeader: Activate expand control
DriveHeader->>SessionFilesPane: Invoke expansion callback
SessionFilesPane->>AgentChatPanel: Pass toggle callback
AgentChatPanel->>useFilesPaneLayout: Toggle expansion
useFilesPaneLayout-->>AgentChatPanel: Return expanded state
AgentChatPanel->>RightPanelSplit: Render full-width Files layout
Possibly related PRs
Merge Risk: ⚪ Minimal · up to The Files controls and layouts appear consistent across the reviewed paths. No issue identified here prevents merging after normal checks. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to The change is primarily presentation behavior and preserves existing session and file-access identities. Remaining uncertainty concerns transient-state recovery, not a demonstrated increase in access or privileges. Retained concerns Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
Resilience and Maintainability Implications
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Website previewPreview URL: https://pr-7346-agenta-website-preview.mahmoud-637.workers.dev Built from |
Contributor
Railway Preview Environment
Dependent tests finished. Post /preview for manual review. Environment absence verified; retained storage requires separate provider accounting. Post |
…ayer Only full-width files take the Settings pane out of layout, so the Build/Chat toggle and the collapse button ease again. Expansion is now a transient record of session, layout action and expanded; the existing eviction effects own the narrow-window case, so a collapsed Settings pane always has a reveal control. The files toggle tooltip opens to the left beside the page edge, the Files region is titled Recent files by default, and the tests keep only assertions that can fail.
Member
Author
|
🤖 The AI agent says: Review pass on 2951aedLive QA recordings (watch first): https://claude.ai/artifact/BuVTQdLrAujGv5ETPVK2Qn (private page with the four MP4s and the measured pane widths; the browser extension that uploads video into GitHub comments was not connected, so the videos live there).
Stack: a standalone EE dev stack built from this head, a throwaway account, and a fresh headless Chromium context per check. Findings fixed
Volume cuts
Accepted trade-offIf the window shrinks below the coexist threshold while files are expanded and Settings is open, the existing eviction effect collapses Settings. That write bumps the layout action counter and ends the expansion, the same thing that happens today with both panes open. Settings stays collapsed with its reveal control visible (check c), and Alt+C reveals it on the first press. Validation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the approved playground file controls to both
/m/and/w/.Durable links and file-pane tabs are deliberately excluded.
Validation
Base:
release/v0.122.1at563c455e3e9c133ef53b82ff68a144c079dbd554.At head
2951aed36c:pnpm lint-fix), and Storybook lint/build passed.Live QA and limits
Separate throwaway account and Docker Compose project
playground-controls-20261005on port8755. No shared production account, stack or data used.Recorded actual
/m/and/w/checks atabc702369dcover synchronized openers, keyboard expansion/restoration, visible divider removal, expanded close, and real text-editor node/draft continuity. File writes were intercepted during the draft continuity scenario. Those recordings use both exact-head CI-built amd64 frontend images from build run37342077784, attempt 1./m/phone checks pass;/w/phone interaction is blocked by its existing minimum-screen overlay, which this change does not modify.The review pass at
2951aed36cwas rechecked on a separate standalone stack built from that head, with a throwaway account: Settings eases on the collapse button, the reveal button and both Build/Chat directions; Expand hides Settings, chat and the session rail and Restore returns every pane to its previous width on/w/and/m/; shrinking below the coexist threshold while expanded ends expansion, leaves the Settings reveal control visible, and one Alt+C reveals Settings. Recordings and measured widths are in the review-pass PR comment.Not verified live: real model streaming, because the available deployment reference has no configured test provider credential; running HTML app counter/bridge continuity, because the app frame remains blank before expansion in this test setup. Synthetic mounted-instance/streaming tests are not substitutes for those live scenarios. These remain QA gaps, not passing claims.
The initial webpack development setup produced an unrelated
/w/boot/CSS error. Switching the isolated deployment to the repository's normal Turbopack development mode resolved it, without repository changes.Storybook build/lint pass. Browser interaction checks and screenshots pass for Playground Controls, Playground Narrow and AgentConfigPaneAlignment. The added play function reaches its completing phase without errors. There are no stored visual baselines for these new examples to compare.
Implicit decisions
Follow-up
At head
2951aed36c95addf4995c087859952ab5d5fe677, 80 checks succeeded and one skipped, with none failing or pending. The runner unit test job failed once on an unrelated timing assertion inturn-admission.test.ts(1799999 vs 1800000 ms) and passed on rerun. CodeRabbit reviewed through this head and stated: “No actionable comments were generated in the recent review.” There are no inline comments or review threads to address.Cleanup verified for both passes: the task containers, networks and volumes are removed, the review-pass images are deleted, and the shared image tags are untouched. No production deployment was performed. The remaining live HTML-app and model-streaming QA gaps above still need resolution before full acceptance.