Skip to content

CurrentState: fix duplicated battery voltage display names - #3783

Open
YQHD711 wants to merge 3 commits into
ArduPilot:masterfrom
YQHD711:pr/misc-fixes
Open

YQHD711 wants to merge 3 commits into
ArduPilot:masterfrom
YQHD711:pr/misc-fixes

Conversation

@YQHD711

@YQHD711 YQHD711 commented Sep 19, 2026

Copy link
Copy Markdown

Battery 3..9 voltage entries all carried [DisplayText("Bat Voltage (V)")], so the Quick/status views could not tell them apart. Each is now Bat3 Voltage (V) ... Bat9 Voltage (V).

Also in this PR, as separate commits:

  • FlightData: initialisation is skipped when the control is instantiated inside the WinForms designer, avoiding designer-time exceptions from runtime-only dependencies.
  • FlightPlanner: removed the hard-coded Simplified-Chinese modal that force-switched the default map to the China Google satellite source, and the hard-coded map-name lookup it depended on. Default map selection is no longer locale-specific.

Testing: built MissionPlanner.sln (Release, net472, VS2022); opened the Quick view and confirmed the battery entries are distinguishable; checked the FlightPlanner map selector.

@YQHD711

YQHD711 commented Sep 27, 2026

Copy link
Copy Markdown
Author

Hi, first-time contributor here. The DotNet Build workflow on this PR is still showing as pending rather than running - it looks like it is waiting for approval to run on a fork PR from a first-time contributor. Could a maintainer approve the workflow when convenient? Happy to adjust anything about the change in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant