Skip to content

FlightData: draw no-threat ADSB traffic green again - #3789

Open
LikoIlya wants to merge 1 commit into
ArduPilot:masterfrom
LikoIlya:fix/adsb-no-threat-green
Open

LikoIlya wants to merge 1 commit into
ArduPilot:masterfrom
LikoIlya:fix/adsb-no-threat-green

Conversation

@LikoIlya

Copy link
Copy Markdown
Contributor

Fixes #3788.

Restores the original ADS-B collision colours on the desktop Flight Data map:

MAV_COLLISION_THREAT_LEVEL Before After
NONE Orange Green
LOW Orange Orange
HIGH Red Red

adac0f3 ("FlightData: change default map draw rate") changed NONE from green to orange. Since then, normal traffic and LOW-threat traffic have looked the same, and the green GMapMarkerADSBPlane icon can never be shown. This brings back the 2016 mapping from e6e0c5c, which the Xamarin Flight Data screen still uses.

If orange for normal traffic was deliberate (see the question in #3788), I'm happy to rework this to make the two builds match the other way and give LOW its own look instead.

One-line change; no other behaviour affected.

🤖 Generated with Claude Code

adac0f3 changed MAV_COLLISION_THREAT_LEVEL.NONE from the green icon
to orange, the same as LOW, so the first collision warning level had
no visual effect and the green icon became unreachable. Go back to the
original NONE -> green / LOW -> orange / HIGH -> red mapping, which the
Xamarin Flight Data screen still uses.

Fixes ArduPilot#3788
@MUSTARDTIGERFPV

Copy link
Copy Markdown
Contributor

I made the same change myself, then ended up reverting it: the green chosen does not stand out enough against a forest or grass area. I take it that's why the original change was made.

@LikoIlya

Copy link
Copy Markdown
Contributor Author

the green chosen does not stand out enough against a forest or grass area

Thanks, that's useful first-hand confirmation. I guessed at that motivation in #3788 but couldn't find it written down anywhere.

So green is out. I still think NONE and LOW shouldn't share the orange icon, though: at the moment the first warning level has no visible effect. How about DeepSkyBlue (#00BFFF) for NONE?

  • It stands out against forest, grass and bare ground.
  • Blue stays distinguishable from orange and red with the most common colour-vision deficiencies. Green vs orange doesn't.
  • Yellow (as on Flightradar24) would sit on the yellow mission route line and be close to the orange of LOW.

A thin white outline would help on any background, but it changes all three icons, so I'd rather do that in a follow-up or if you want it there, i'll add it in PR too.

If that works for everyone, I'll rework this PR: a new blue icon for NONE, LOW orange and HIGH red unchanged, and the same mapping on Xamarin so both builds match again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ADSB: no-threat traffic drawn orange (same as LOW) on desktop, green on Xamarin — intended?

2 participants