[Autonomost]

Every page that subscribes to POI.POIModified (FlightData and FlightPlanner) triggered a load of poi.txt from the event's add accessor, so each start doubled the in-memory list, and the next save wrote the doubled list back. After a few sessions the map shows stacks of identical markers; one affected poi.txt had 1280 lines for 16 distinct points.

The saved file is now read on the first subscription only, and a page that subscribes later draws the list already held. LoadFile skips an entry whose position and name are already held, so loading a file twice, or a file that already contains duplicates, cannot pile markers up. When the saved file held duplicates it is rewritten clean at startup, which repairs existing installs on their next start. Malformed lines are ignored instead of throwing out of the loader.

The second commit addresses review:

• A failed read (the file held open by a virus scanner, a sync client or another instance) is no longer treated as loaded. It is retried on the next subscription, and the list is not written to poi.txt until the file has been read, so a failed read can no longer end with the next add, edit or delete saving a list without the saved POIs over the file.
• poi.txt is opened read only and shared. File.Open(path, FileMode.Open) asks for read/write access with no sharing, which fails whenever another program has the file open.
• The duplicate repair only rewrites poi.txt at startup. Importing a file with Load file writes neither poi.txt nor the imported file.
• Duplicates are matched on the position as the file stores it (15 significant digits), so a point placed on the map matches the same point read back from a saved file.
• With the file loaded once, the page that subscribed second (normally Plan, which subscribes when first opened) was not drawn until a POI changed. It now draws when it subscribes.

The third commit logs a failed startup read and the two failure paths after it, uses items.Length, and gives SaveFile and the duplicate key one shared CoordText helper so the key is always exactly the text the file holds.

The fourth commit (after the merge of master) stops relying on File.Exists to decide that there is no saved file: File.Exists is also false for a file the process cannot read, which would have marked an inaccessible poi.txt as loaded and let the next edit write over it. Only "not found" now counts as no file; any other read failure is logged and retried on the next subscription, with the file left unwritten until then.

The first commit was verified on a real 1280-line poi.txt: the first start rewrote it to 16 lines and the markers are no longer stacked. The review changes are covered by unit tests in our fork (locked file read again on the next subscription, failed read not overwritten, file open in another program, unreadable file not overwritten, import leaves both files alone, re-import after placing a point, later page drawn). They need InternalsVisibleTo on the main assembly, so they are not included here.

[Copilot]

Copilot review overview

🟡 Changes recommended

Address import-file rewriting and POI loading/subscriber initialization issues.

Review effort: Lite
Findings: 1 · 1

Open (2)

• LoadFile overwrites the default file instead of the selected import · New
• Load failures permanently prevent later POI loading retries · New

What changed in this PR

Updates POI loading to prevent duplicate markers and clean malformed or repeated entries.

Changes:

• Loads the saved POI file once.
• Deduplicates entries and ignores malformed records.
• Rewrites cleaned POI data.

File	Summary
Utilities/​POI.cs	Updates POI loading, deduplication, and persistence behavior.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Copilot review overview

Review effort: Lite
Findings: 1 · 3

Open (4)

• pnt.Tag is treated as a string here. If PointLatLngAlt.Tag is typed as object (common in map… · New
• This catch swallows all exceptions and returns false with no diagnostic signal. Since a failed… · New
• items is an array, so items.Length should be used instead of items.Count(). Count() adds… · New
• The comment says this matches the position \"as SaveFile writes it\" (15 significant digits), but… · New

Resolved since last review (2)

• LoadFile overwrites the default file instead of the selected import
• Load failures permanently prevent later POI loading retries

[Autonomost]

@meee1 feel free to give it another review.

[Copilot]

Copilot review overview

🟡 Changes recommended

An unresolved critical issue may mark inaccessible files as loaded and overwrite them.

Review effort: Lite
Findings: 1

Open (1)

• Treat inaccessible POI files as load failures · New

Resolved since last review (4)

• pnt.Tag is treated as a string here. If PointLatLngAlt.Tag is typed as object (common in map…
• The comment says this matches the position \"as SaveFile writes it\" (15 significant digits), but…
• items is an array, so items.Length should be used instead of items.Count(). Count() adds…
• This catch swallows all exceptions and returns false with no diagnostic signal. Since a failed…

[Autonomost]

Merged upstream master (694628a) into the branch as 4580a2e. It brings a489d27, which fixes the Mavlink.cs syntax errors behind every red CI run here since 2026-09-30 (the last run on a2c8df1 had 890 of them, all in Mavlink.cs, none in POI.cs), plus the commits since. No conflicts; the PR's own change is untouched, and the branch builds on Windows (MissionPlanner.csproj, Release).

[Autonomost]

@meee1 this should be good to go.

[Copilot]

🔵 Needs a closer look

Ensure redraw still occurs when duplicate-file repair fails.

No open issues 🎉

1 resolved since last review

• Treat inaccessible POI files as load failures

_{Review effort: Lite}