Repository navigation
Fix assy-STEP roundtrip with complete solids tagged as subshapes - #2127
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2127 +/- ##
=======================================
Coverage 95.81% 95.81%
=======================================
Files 30 30
Lines 9605 9612 +7
Branches 1443 1446 +3
=======================================
+ Hits 9203 9210 +7
Misses 247 247
Partials 155 155 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jmwright
approved these changes
Nov 8, 2026
jmwright
left a comment
jmwright
left a comment
Member
There was a problem hiding this comment.
Thanks @adam-urbanczyk I just had the one comment.
adam-urbanczyk
commented
Nov 8, 2026
lorenzncode
approved these changes
Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2121 When importing STEPs, the STEP Model is checked for potentially missed subshape names of solid entites.