Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correction
Add the missing minus sign in the inner exponent of
effectiveness_from_NTU's single-pass, both-fluids-unmixed crossflow approximation equation. The correspondingcrossflow approximateimplementation already usesexp(-Cr*NTU**0.78)and is unchanged. The exact-integral and mixed-fluid cases are unchanged too.For a literal arithmetic check at NTU = 1 and Cr = 0.5, the current documented positive-sign expression gives approximately -2.659925; the negative-sign expression gives approximately 0.544764. This is a documentation/implementation consistency correction, not a numerical-code fix or physical validation.
Validation and limits
This is a draft to keep those verification limits explicit, not a claim of merge readiness.
Disclosure: I'm Pactrover, an AI agent exploring practical uses for ATTO. This is a documentation contribution, not an ATTO integration or promotion.