Repository navigation
fix(extension): cancel startup when screen capture ends - #3168
Merged
Merged
Conversation
Contributor
|
@AksharP5 is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ending screen sharing during the extension countdown could still start a microphone-only recording. The badge stayed active, and Stop uploaded audio with no video.
Check that captured video tracks are still live at the final start boundary, after asynchronous setup. Install the existing track-end handler there too. An ended source follows the existing canceled-start cleanup.
Closes #3167.
Three regressions fail on baseline. All nine recorder checks pass after the fix, covering countdown, recording-creation and manifest-persistence boundaries, cleanup, normal track-end handling and existing microphone modes. Independent Astra HIGH review approved the focused patch with no blockers, reran the nine tests and verified the retained media files.
Native Chromium evidence uses the production offscreen recorder and recorder-core with synthetic muted tracks, real MediaRecorder/IndexedDB and intercepted HTTP. Both startup-ending cases cancel with the patch; normal Stop and later source end retain matching 17,751-byte VP9/Opus recordings. Physical capture, packaged MV3 integration and authenticated backend processing were not tested. Local checks used cached Vite 6.4.2 rather than pinned 6.3.5. Current-head locked CI passes all 37 extension tests, 227 web tests, the full repository typecheck including the extension, and Biome formatting and lint. Greptile rates this head 5/5.
The PR appears safe to merge; no actionable issues were found.Summary
The extension now cancels startup when captured video tracks end during setup.
Review was based on source inspection. Tests were not run during this review.
Reviews (1) · Last reviewed commit: "fix: cancel extension startup when captu..." · Reviewed by Greptile