Repository navigation
Bump ClickHouse.Driver to 1.5.0 - #69
Merged
Merged
Conversation
Move the driver pin from 1.4.0 to 1.5.0 in the provider and in both test projects. The three pins must move together, or restore fails with NU1605. v0.3.1 is not released, so the Dependencies entry in CHANGELOG.md and RELEASENOTES.md now records the net change for the release, 1.3.0 to 1.5.0. The 1.4.0 behaviour notes stay, and are marked as 1.4.0 changes. Two 1.5.0 changes apply to the provider's HTTP/ADO.NET path: - A DateTime/DateTime64 column whose Fixed/UTC timezone name has a minute or second field above 59 (Fixed/UTC+05:60:00 is +06:00 on the server) now reads with the correct wall clock. The driver read it as UTC. - ClickHouseBulkCopySerializationException has RowIndex, the zero-based position of the failed row in the batch. The rest of 1.5.0 is the experimental native TCP client. It has no ADO.NET layer, so the provider does not use it. No source changes were needed. The solution builds with 0 errors and 326 warnings, which is the existing baseline. project.assets.json resolves ClickHouse.Driver 1.5.0 in every project. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the
ClickHouse.Driverpin from 1.4.0 to 1.5.0 in the provider and in both test projects. The three pins must move together, or restore fails withNU1605. No source changes are needed.What 1.5.0 changes for the provider
Two changes apply to the HTTP/ADO.NET path that the provider uses:
Fixed/UTCtimezone read fix. ADateTime/DateTime64column whoseFixed/UTC±HH:MM:SStimezone name has a minute or second field above 59 now reads with the correct wall clock. Servers before ClickHouse 26.10 carry the excess into the next field, soFixed/UTC+05:60:00is+06:00; 26.10 rejects the name. The driver rejected such a name and read the value as UTC. (clickhouse-cs#612)RowIndexonClickHouseBulkCopySerializationException. When an insert fails because a value cannot be serialized, the exception gives the zero-based position of the failed row in the driver batch. This applies toSaveChangesandBulkInsertAsync, which both useInsertBinaryAsync. The driver starts a new batch everyInsertOptions.BatchSizerows (100,000 by default), andSaveChangesmakes one insert call for each table and column set, so the index is not a position in the EF batch or in the input sequence. (clickhouse-cs#608)The rest of 1.5.0 is the experimental native TCP client (
ClickHouseTcpClient). It has no ADO.NET layer, so the provider does not use it.Docs
v0.3.1 is not released, so the Dependencies entry in
CHANGELOG.mdandRELEASENOTES.mdnow records the net change for the release, 1.3.0 to 1.5.0. The existing 1.4.0 behaviour notes (zstd responses,InvalidOperationExceptionon a reader with no current row) stay, and are marked as 1.4.0 changes.Verification
ClickHouse.Driver1.5.0 in every project (checked inproject.assets.json), with noNUwarnings.dotnet build --no-incremental: 0 errors, 326 warnings. This is the existing baseline, so 1.5.0 adds no warnings.Effect on open PRs
DateTimeOffsetmapping) says in the README that the driver does not read aFixed/UTCname with a field above 59, so the read throws. With 1.5.0 the driver reads such a name. Map DateTimeOffset to DateTime64 and fix composite component reads (#53) #63 should check that statement and its test after it rebases onto this change.🤖 Generated with Claude Code