Skip to content

Bump ClickHouse.Driver to 1.4.0 + allow DateTime elements in Array columns - #2

Merged
alex-clickhouse merged 2 commits into
mainfrom
alex-clickhouse/bump-driver-1.4.0-rc1
Sep 2, 2026
Merged

alex-clickhouse merged 2 commits into
mainfrom
alex-clickhouse/bump-driver-1.4.0-rc1

Conversation

@alex-clickhouse

@alex-clickhouse alex-clickhouse commented Aug 19, 2026 •

Copy link
Copy Markdown
Collaborator

What

Two commits:

  1. Bump ClickHouse.Driver from 1.3.0 to the final 1.4.0 release.
  2. Allow DateTime/DateTimeOffset elements in Array columns — a stale-TODO
    cleanup in the type map, with the coverage it unblocks.

This PR originally validated 1.4.0-rc1. Now that 1.4.0 is on NuGet it has been
retargeted at the final release and re-verified from scratch — not just a
version-string swap. Real behaviour changed between rc1 and final, including
"throw instead of dropping data for overlapping JSON paths", a JSON parent-walk
fix, and a new insert-query-placement option that touched IBatchSerializer.

Why

Keep the connector on the current released driver, and confirm 1.4.0 is a clean
drop-in before downstream users hit it.

On the second commit: ClickHouseTypeMap excluded DateTime and DateTimeOffset
as collection element types, with a TODO waiting on the driver to quote
DateTime64 elements inside Array(...) parameters.

That TODO was stale — it is not something 1.4.0 fixed. Verified against a real
server: the round-trip succeeds on 1.4.0 and equally on 1.3.0, which is this
repo's effective driver floor (1.2.0 does not compile here — the
ClickHouseClientSettings.ApplicationInfo API is 1.3.0+). So the driver
limitation the TODO describes is unreachable from any driver version this repo
supports. Worth stating plainly, because the tempting conclusion — "1.4.0
unblocked this" — is wrong.

Re-enabling the type-map check unblocks more surface than the single
commented-out field, so coverage was extended to DateTimeOffset[] and
List<DateTime> — neither of which was covered before.

Testing

All local, against driver 1.4.0 with the resolved version confirmed in both
project.assets.json and the built deps.json rather than assumed.

  • dotnet build --no-restore -c Release --no-incremental —
    0 errors, 0 warnings. TreatWarningsAsErrors is Release-only in this
    repo, so Release is the configuration that matters.
  • test/ClickHouse.Tests (unit) — 6 passed, 0 failed, 0 skipped
  • test/ClickHouse.ConformanceTests — 167 passed, 0 failed, 0 skipped
    (runs against a real ClickHouse via Testcontainers)

Note

test/VectorData.ConformanceTests/packages.lock.json drifts on any dotnet restore in this repo. That is pre-existing on main and unrelated to this
change, so it has been kept out of the diff.

Changelog

No entry — this repo has no CHANGELOG.md / RELEASENOTES.md. release.yml
uses generateReleaseNotes: true, so GitHub builds the notes from merged PR
titles; this PR's title is the changelog entry. Adding a changelog file here
would invent a convention the repo deliberately does not use.

🤖 Generated with Claude Code

@codecov

codecov Bot commented Aug 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@alex-clickhouse alex-clickhouse changed the title Bump ClickHouse.Driver to 1.4.0-rc1 Bump ClickHouse.Driver to 1.4.0-rc1 + allow DateTime elements in Array columns Aug 19, 2026
alex-clickhouse and others added 2 commits September 2, 2026 07:58
Moves the driver pin from 1.3.0 to the final 1.4.0 release.

Verified locally against driver 1.4.0 (resolved version confirmed in
project.assets.json and the built deps.json, not assumed):

- Build: BUILD SUCCEEDED, 0 errors, 0 warnings in Release with
  --no-incremental. TreatWarningsAsErrors is Release-only in this repo,
  so Release is the configuration that matters.
- test/ClickHouse.Tests (unit): 6 passed, 0 failed, 0 skipped.
- test/ClickHouse.ConformanceTests: 167 passed, 0 failed, 0 skipped.

No source changes were required for the bump itself.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The type map excluded DateTime and DateTimeOffset as collection element
types, with a TODO waiting on ClickHouse.Driver to quote DateTime64
elements inside Array(...) parameters.

That restriction is stale. Verified empirically against a real server:
the round-trip succeeds on 1.4.0 and equally on 1.3.0, which is this
repo's effective floor (1.2.0 does not compile here — ClickHouseClientSettings
.ApplicationInfo is 1.3.0+). So the driver limitation the TODO describes is
not reachable from any driver version this repo supports. This is therefore
a stale-TODO cleanup, not something 1.4.0 unblocked.

Re-enables the commented-out DateTime[] coverage and extends it to the rest
of the surface the type-map change unblocks — DateTimeOffset[] and
List<DateTime> — neither of which was covered before.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@alex-clickhouse
alex-clickhouse force-pushed the alex-clickhouse/bump-driver-1.4.0-rc1 branch from 88fd803 to 171ccca Compare September 2, 2026 07:58
@alex-clickhouse alex-clickhouse changed the title Bump ClickHouse.Driver to 1.4.0-rc1 + allow DateTime elements in Array columns Bump ClickHouse.Driver to 1.4.0 + allow DateTime elements in Array columns Sep 2, 2026
@alex-clickhouse
alex-clickhouse marked this pull request as ready for review September 2, 2026 08:14
@alex-clickhouse
alex-clickhouse merged commit 4fa9b25 into main Sep 2, 2026
4 checks passed
@alex-clickhouse
alex-clickhouse deleted the alex-clickhouse/bump-driver-1.4.0-rc1 branch September 2, 2026 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant