Repository navigation
Bump ClickHouse.Driver to 1.4.0 + allow DateTime elements in Array columns - #2
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Moves the driver pin from 1.3.0 to the final 1.4.0 release. Verified locally against driver 1.4.0 (resolved version confirmed in project.assets.json and the built deps.json, not assumed): - Build: BUILD SUCCEEDED, 0 errors, 0 warnings in Release with --no-incremental. TreatWarningsAsErrors is Release-only in this repo, so Release is the configuration that matters. - test/ClickHouse.Tests (unit): 6 passed, 0 failed, 0 skipped. - test/ClickHouse.ConformanceTests: 167 passed, 0 failed, 0 skipped. No source changes were required for the bump itself. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The type map excluded DateTime and DateTimeOffset as collection element types, with a TODO waiting on ClickHouse.Driver to quote DateTime64 elements inside Array(...) parameters. That restriction is stale. Verified empirically against a real server: the round-trip succeeds on 1.4.0 and equally on 1.3.0, which is this repo's effective floor (1.2.0 does not compile here — ClickHouseClientSettings .ApplicationInfo is 1.3.0+). So the driver limitation the TODO describes is not reachable from any driver version this repo supports. This is therefore a stale-TODO cleanup, not something 1.4.0 unblocked. Re-enables the commented-out DateTime[] coverage and extends it to the rest of the surface the type-map change unblocks — DateTimeOffset[] and List<DateTime> — neither of which was covered before. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
alex-clickhouse
force-pushed
the
alex-clickhouse/bump-driver-1.4.0-rc1
branch
from
September 2, 2026 07:58
88fd803 to
171ccca
Compare
alex-clickhouse
marked this pull request as ready for review
September 2, 2026 08:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two commits:
ClickHouse.Driverfrom 1.3.0 to the final 1.4.0 release.DateTime/DateTimeOffsetelements inArraycolumns — a stale-TODOcleanup in the type map, with the coverage it unblocks.
This PR originally validated
1.4.0-rc1. Now that 1.4.0 is on NuGet it has beenretargeted at the final release and re-verified from scratch — not just a
version-string swap. Real behaviour changed between rc1 and final, including
"throw instead of dropping data for overlapping JSON paths", a JSON parent-walk
fix, and a new insert-query-placement option that touched
IBatchSerializer.Why
Keep the connector on the current released driver, and confirm 1.4.0 is a clean
drop-in before downstream users hit it.
On the second commit:
ClickHouseTypeMapexcludedDateTimeandDateTimeOffsetas collection element types, with a TODO waiting on the driver to quote
DateTime64elements insideArray(...)parameters.That TODO was stale — it is not something 1.4.0 fixed. Verified against a real
server: the round-trip succeeds on 1.4.0 and equally on 1.3.0, which is this
repo's effective driver floor (1.2.0 does not compile here — the
ClickHouseClientSettings.ApplicationInfoAPI is 1.3.0+). So the driverlimitation the TODO describes is unreachable from any driver version this repo
supports. Worth stating plainly, because the tempting conclusion — "1.4.0
unblocked this" — is wrong.
Re-enabling the type-map check unblocks more surface than the single
commented-out field, so coverage was extended to
DateTimeOffset[]andList<DateTime>— neither of which was covered before.Testing
All local, against driver
1.4.0with the resolved version confirmed in bothproject.assets.jsonand the builtdeps.jsonrather than assumed.dotnet build --no-restore -c Release --no-incremental—0 errors, 0 warnings.
TreatWarningsAsErrorsis Release-only in thisrepo, so Release is the configuration that matters.
test/ClickHouse.Tests(unit) — 6 passed, 0 failed, 0 skippedtest/ClickHouse.ConformanceTests— 167 passed, 0 failed, 0 skipped(runs against a real ClickHouse via Testcontainers)
Note
test/VectorData.ConformanceTests/packages.lock.jsondrifts on anydotnet restorein this repo. That is pre-existing onmainand unrelated to thischange, so it has been kept out of the diff.
Changelog
No entry — this repo has no
CHANGELOG.md/RELEASENOTES.md.release.ymluses
generateReleaseNotes: true, so GitHub builds the notes from merged PRtitles; this PR's title is the changelog entry. Adding a changelog file here
would invent a convention the repo deliberately does not use.
🤖 Generated with Claude Code