Repository navigation
[jdbc-v2] Fix Array#getResultSet() for createArrayOf arrays and geo values #3376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Indian-boult
wants to merge
2
commits into
ClickHouse:main
Choose a base branch
from
Indian-boult:fix/array-resultset-element-column
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| - **[jdbc-v2]** Fixed `java.sql.Array#getResultSet()` and `getResultSet(long, int)` for an array from | ||
| `Connection#createArrayOf` and for a geo value read with `ResultSet#getArray`. For a scalar element type such as | ||
| `Int32`, `Nullable(String)` or `Date`, and for `Point`, `Ring`, `LineString`, `MultiPoint`, `Polygon`, | ||
| `MultiLineString` and `MultiPolygon` values, they threw an unchecked `IndexOutOfBoundsException`. For a `Tuple` or | ||
| `Map` element type, the `VALUE` column had the type of the first tuple field or of the map key, so `getObject(2)` | ||
| failed. Now the `VALUE` column of an array from `createArrayOf` has the element type, the same as the `VALUE` column | ||
| of an `Array(T)` value read from the server. The `VALUE` column of a geo value has the geo element type, the one | ||
| that ClickHouse 26.10 returns for `x[1]`. `Ring`, `LineString` and `MultiPoint` have `Point` elements, `Polygon` has | ||
| `Ring` elements, `MultiLineString` has `LineString` elements, `MultiPolygon` has `Polygon` elements, and a `Point` | ||
| has `Float64` coordinates. `getBaseTypeName()` does not change. A `Tuple` or `Geometry` value read with `getArray` | ||
| now reports its own type for the `VALUE` column, the same as `getBaseTypeName()`, and not the type of its first | ||
| field or variant. An array from `createArrayOf` with a geo element type such as `Ring` holds whole `Ring` values, so | ||
| its `VALUE` column is `Ring`, the same as for `Array(Ring)`. | ||
| (https://github.com/ClickHouse/clickhouse-java/issues/3216) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.