Repository navigation
Fix resolution of registered generic collection formatters - #464
Open
dajiaohuang wants to merge 1 commit into
Open
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The public
RegisterCollection(Type),RegisterSet(Type)andRegisterDictionary(Type)overloads accept open generic collection definitions, but serializing a closed instance still throwsMemoryPackSerializationExceptionsaying it is not registered. For example:Registration stores the open generic definition as the key, while resolution looks up the constructed type. The formatter construction also needs the constructed type's actual generic arguments, not the definition's unbound parameters.
Change
Look up the generic definition and close the formatter with the collection type and its actual generic arguments. No wire-format or public API change.
Add public serialize/deserialize regression tests for all three registration overloads, covering both generic and runtime-Type APIs and nullable collection elements/dictionary values.
Validation
f96ba3054f14e528b5f75eba4ff02de0b71fa64awith the not-registered exception and pass with the fix.