Repository navigation
test(dgw): drop the devolutions-gateway dev-dependency - #2101
Open
Benoît Cortier (CBenoit) wants to merge 2 commits into
Open
Benoît Cortier (CBenoit) wants to merge 2 commits into
Benoît Cortier (CBenoit) wants to merge 2 commits into
Conversation
Member
Author
|
Validation on Windows:
Note LLM-assisted content (no human feedback). |
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The cross-process QUIC and WebSocket test migration needs runtime validation and final human review.
1 open finding
What changed in this PR
Removes the testsuite’s Gateway library dependency by moving routing tests to the shipped binary, addressing #2090.
Changes:
- Tests KDC, forwarding, and JMUX through public endpoints with a fake Agent.
- Builds token claims as JSON and preserves listener-library tests.
- Removes unused dependencies and internal test helpers.
| File | Description |
|---|---|
| testsuite/tests/cli/dgw/mod.rs | Registers new test modules. |
| testsuite/tests/cli/dgw/kdc_proxy.rs | Adds binary-driven KDC routing tests. |
| testsuite/tests/cli/dgw/jmux.rs | Tests JMUX routing over WebSocket. |
| testsuite/tests/cli/dgw/fwd_tcp.rs | Tests forwarding and fallback behavior. |
| testsuite/tests/cli/dgw/fake_agent.rs | Adds enrollment and QUIC test support. |
| testsuite/tests/cli/agent/tunnel.rs | Replaces Gateway claim types with JSON. |
| testsuite/tests/agent_tunnel/mod.rs | Updates module visibility and organization. |
| testsuite/tests/agent_tunnel/listener.rs | Preserves four listener-library tests. |
| testsuite/tests/agent_tunnel/kdc.rs | Removes replaced internal KDC tests. |
| testsuite/tests/agent_tunnel/integration.rs | Removes migrated integration tests. |
| testsuite/tests/agent_tunnel/common.rs | Exposes shared helpers and removes unused ones. |
| testsuite/Cargo.toml | Removes Gateway and nonempty dependencies. |
| Cargo.lock | Updates testsuite dependency entries. |
🧠 Review effort: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Linking the Gateway library pulled axum, hyper, rustls, and the rest of the Gateway into the test binary, and let tests rebuild Gateway internals in-process instead of driving the shipped binary. The agent-routed KDC, forwarding, and JMUX tests now start the Gateway binary and use a stand-in Agent that enrolls over HTTP and speaks the agent tunnel protocol over QUIC. Token claims are plain JSON. No Gateway source change was needed. Fixes #2090 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Benoît Cortier (CBenoit)
force-pushed
the
cbenoit-drop-gateway-dev-dependency
branch
from
October 21, 2026 20:36
d487ed9 to
8b1448b
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Linking the Gateway library pulled axum, hyper, rustls, and the rest of the Gateway into the test binary, and let tests rebuild Gateway internals in-process instead of driving the shipped binary.
The agent-routed KDC, forwarding, and JMUX tests now start the Gateway binary and use a stand-in Agent (
cli/dgw/fake_agent.rs) that enrolls through/jet/tunnel/enrolland speaks the agent tunnel protocol over QUIC with theagent-tunnel-protocrate.Token claims are plain JSON.
No Gateway source change or
__debug__knob was needed.nonemptywas only used with Gateway types and is removed too.cli::agent::tunnel(claim building)kdc::kdc_connector_relays_tcp_through_a_matching_agentcli::dgw::kdc_proxy::kdc_proxy_relays_tcp_through_a_matching_agent/jet/KdcProxy; the stand-in Agent checks the session ID (tokenjti), the target, and the relayed bytes.kdc::kdc_connector_falls_back_to_direct_tcp_without_a_matching_routekdc_proxy_falls_back_to_direct_tcp_without_a_matching_route/jet/KdcProxy.kdc::kdc_connector_rejects_udp_selected_for_an_agent_routekdc_proxy_rejects_udp_selected_for_an_agent_routekdc::kdc_connector_rejects_udp_for_an_explicit_agent_before_dialingkdc_proxy_rejects_udp_for_an_explicit_agent_before_dialingkdc::kdc_connector_rejects_an_explicit_missing_agentkdc_proxy_never_dials_the_kdc_directly_for_a_missing_explicit_agent, which also checks that the KDC is never dialed.integration::gateway_connect_upstream_routes_wildcard_domain_without_subnetscli::dgw::fwd_tcp::fwd_routes_wildcard_domain_without_subnets/jet/fwd/tcp.integration::gateway_connect_upstream_falls_back_to_direct_tcp_without_a_routefwd_falls_back_to_direct_tcp_without_a_route/jet/fwd/tcp.integration::gateway_connect_upstream_uses_explicit_agent_without_a_matching_routefwd_uses_explicit_agent_without_a_matching_routeintegration::gateway_connect_upstream_tries_the_next_matching_agentfwd_tries_the_next_matching_agentintegration::gateway_connect_upstream_does_not_bypass_failed_agent_routesfwd_does_not_bypass_failed_agent_routesintegration::gateway_jmux_*(4 tests)cli::dgw::jmux::jmux_*/jet/jmuxwith JMUX frames over WebSocket. The disabled-tunnel case asserts close code 1011.integration::gateway_listener_*(4 tests)agent_tunnel/listener.rsagent-tunnellibrary.Fixes #2090