Skip to content

fix(dgw,agent): match proxy exclusions on label boundaries - #2105

Draft
Benoît Cortier (CBenoit) wants to merge 1 commit into
masterfrom
cbenoit-fix-proxy-exclude-boundary
Draft

Benoît Cortier (CBenoit) wants to merge 1 commit into
masterfrom
cbenoit-fix-proxy-exclude-boundary

Conversation

@CBenoit

Copy link
Copy Markdown
Member

A .corp.local exclusion also matched evilcorp.local, because the suffix check compared the domain without its leading dot. Requests to such hosts bypassed the configured proxy. An exclusion now matches the domain itself or a host ending with the dotted pattern.

This affects manual proxy mode in Devolutions Gateway and in the Devolutions Agent updater.

Co-authored-by: Copilot App 223556219+Copilot@users.noreply.github.com

A `.corp.local` exclusion also matched `evilcorp.local`, because the
suffix check compared the domain without its leading dot. Requests to
such hosts bypassed the configured proxy. An exclusion now matches the
domain itself or a host ending with the dotted pattern.

This affects manual proxy mode in Devolutions Gateway and in the
Devolutions Agent updater.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant