Repository navigation
fix(dgw,agent): match proxy exclusions on label boundaries - #2105
Draft
Benoît Cortier (CBenoit) wants to merge 1 commit into
Draft
Benoît Cortier (CBenoit) wants to merge 1 commit into
Benoît Cortier (CBenoit) wants to merge 1 commit into
Conversation
A `.corp.local` exclusion also matched `evilcorp.local`, because the suffix check compared the domain without its leading dot. Requests to such hosts bypassed the configured proxy. An exclusion now matches the domain itself or a host ending with the dotted pattern. This affects manual proxy mode in Devolutions Gateway and in the Devolutions Agent updater. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
.corp.localexclusion also matchedevilcorp.local, because the suffix check compared the domain without its leading dot. Requests to such hosts bypassed the configured proxy. An exclusion now matches the domain itself or a host ending with the dotted pattern.This affects manual proxy mode in Devolutions Gateway and in the Devolutions Agent updater.
Co-authored-by: Copilot App 223556219+Copilot@users.noreply.github.com