Skip to content

refactor(agent,jetsocat): apply workspace lints to shipped crates - #2205

Open
Alex Yusiuk (RRRadicalEdward) wants to merge 1 commit into
masterfrom
refactor/workspace-lints-shipped-crates
Open

Alex Yusiuk (RRRadicalEdward) wants to merge 1 commit into
masterfrom
refactor/workspace-lints-shipped-crates

Conversation

@RRRadicalEdward

Copy link
Copy Markdown
Collaborator

The PEDM hook, PEDM shell extension, PEDM shared library and mcp-proxy declared an empty [lints] table, which opted them out of the workspace lints even though they ship in the Agent and Jetsocat. Inherit the workspace lints and address the warnings:

  • Narrow unreachable pub items in the PEDM hook to pub(crate).
  • Split unsafe blocks so each holds one operation, and document the remaining unsafe blocks.
  • Replace as _ casts with cast_signed, cast_unsigned, u32::from and explicit pointer casts.
  • Return errors from build scripts instead of unwrapping.
  • Drop the redundant unsafe impl Send and Sync for NamedPipeStream, which NamedPipeClient already provides.
  • Allow inline_always and transmute_ptr_to_ptr in the shell extension, where the windows-core #[implement] and #[interface] macros generate them.
  • Expect the truncating JSON-RPC id cast in mcp-proxy.

The PEDM hook, PEDM shell extension, PEDM shared library and
mcp-proxy declared an empty `[lints]` table, which opted them out of
the workspace lints even though they ship in the Agent and Jetsocat.
Inherit the workspace lints and address the warnings:

- Narrow unreachable `pub` items in the PEDM hook to `pub(crate)`.
- Split unsafe blocks so each holds one operation, and document the
  remaining unsafe blocks.
- Replace `as _` casts with `cast_signed`, `cast_unsigned`,
  `u32::from` and explicit pointer casts.
- Return errors from build scripts instead of unwrapping.
- Drop the redundant `unsafe impl Send` and `Sync` for
  `NamedPipeStream`, which `NamedPipeClient` already provides.
- Allow `inline_always` and `transmute_ptr_to_ptr` in the shell
  extension, where the windows-core `#[implement]` and `#[interface]`
  macros generate them.
- Expect the truncating JSON-RPC id cast in mcp-proxy.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

Let maintainers know that an action is required on their side

  • Add the label release-required Please cut a new release (Devolutions Gateway, Devolutions Agent, Jetsocat, PowerShell module) when you request a maintainer to cut a new release (Devolutions Gateway, Devolutions Agent, Jetsocat, PowerShell module)

  • Add the label release-blocker Follow-up is required before cutting a new release if a follow-up is required before cutting a new release

  • Add the label publish-required Please publish libraries (`Devolutions.Gateway.Utils`, OpenAPI clients, etc) when you request a maintainer to publish libraries (Devolutions.Gateway.Utils, OpenAPI clients, etc.)

  • Add the label publish-blocker Follow-up is required before publishing libraries if a follow-up is required before publishing libraries

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants