Skip to content

fix(ui): align button height and remove extra bottom padding in toggle panels - #5679

Open
mudravadev wants to merge 1 commit into
Dokploy:canaryfrom
mudravadev:fix/ui-settings-alignment
Open

mudravadev wants to merge 1 commit into
Dokploy:canaryfrom
mudravadev:fix/ui-settings-alignment

Conversation

@mudravadev

@mudravadev mudravadev commented Oct 14, 2026 •

Copy link
Copy Markdown

What is this PR about?

Two small UI alignment fixes in the settings pages:

  1. On Settings > Server the "Check for updates" button was rendered with size="sm" (36px) while its sibling buttons (Server / Traefik / Space) use the default size (40px), so the row looked misaligned. Removed the size prop from the trigger button.

  2. FormItem applies space-y-3 by default, which adds margin-bottom to its children even when the item is laid out as a flex-row toggle panel. This produced extra bottom padding inside every bordered toggle panel (HTTPS, Daily Docker Cleanup, Rate Limiting, etc.). Added space-y-0 to all 39 flex-row FormItem usages so the panels keep their own padding only.

Checklist

Before submitting this PR, please make sure that:

Issues related (if applicable)

No related issue.

Screenshots (if applicable)

Button height, before (Check for updates is 36px, others 40px):

buttons-before

After (all 4 buttons 40px):

buttons-after

Toggle panel bottom padding, before (extra 12px below the HTTPS row, panel 74px):

panel-before

After (panel 62px):

panel-after

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge.

Summary

This PR fixes two dashboard alignment issues:

  • Toggle panels no longer have extra space below their contents.
  • The update button matches the height of its neighbors.

No actionable issues found.

Reviews (1) · Last reviewed commit: "fix(ui): align button height and remove ..." · Reviewed by Greptile

…e panels

The update trigger on Settings > Server used size sm while its grid
neighbors use the default size, making it 4px shorter. Horizontal
FormItem panels inherit space-y-3 from the base component, which adds a
12px bottom margin to every child and inflates the panel below its
content; reset it with space-y-0 in all such panels.
@mudravadev
mudravadev marked this pull request as ready for review October 14, 2026 22:36
@narcisonunez narcisonunez added hotfix Cherry-pick this fix to main for next patch release and removed hotfix Cherry-pick this fix to main for next patch release labels Oct 15, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants