Skip to content

chore(langfuse): move integration to plugins repository - #418

Open
Yangtze-Seventh wants to merge 1 commit into
mainfrom
chore/move-langfuse-integration
Open

Yangtze-Seventh wants to merge 1 commit into
mainfrom
chore/move-langfuse-integration

Conversation

@Yangtze-Seventh

Copy link
Copy Markdown
Contributor

Summary

  • remove the ecosystem-facing examples/langfuse directory after migrating it to EverMind-AI/plugins/langfuse
  • keep EverOS native OpenTelemetry tracing, Langfuse-compatible attributes, recall-score delivery, configuration, and all core tests unchanged
  • preserve historical CHANGELOG entries and repository topics

Companion migration: EverMind-AI/Plugins#10

Scope verification

  • the diff deletes exactly the six tracked files under examples/langfuse
  • no source, dependency, configuration, test, README, or workflow file changes
  • no remaining live references to examples/langfuse outside historical CHANGELOG entries

Tests

  • PYTHONPATH=src python -m pytest -q tests/unit/test_config/test_observability_settings.py tests/unit/test_core/test_observability tests/unit/test_core/test_lifespan/test_tracing_lifespan.py tests/unit/test_service/test_memorize_span.py
  • result: 53 passed

@gloryfromca gloryfromca left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking: Land a mergeable companion migration before deleting the current integration.

The revision deletes the only runnable/documented Langfuse integration from EverOS, but EverMind-AI/plugins#10 is still open and currently conflicted; plugins main does not contain langfuse/ yet. If this PR lands first, released main has no replacement for the removed replay/demo/recording workflow. Please merge (or otherwise make available) the companion migration first, then this cleanup can safely follow.

I covered CLAUDE.md and all applicable .claude/rules, the complete origin/main...HEAD deletion diff, repository callers/references and history, backward compatibility of the example workflow, unchanged tests, and the DDD/observability architecture. I refuted code-level concerns: all core Langfuse-compatible OpenTelemetry settings, attributes, score delivery, and their tests remain unchanged; the five non-README artifacts are byte-identical in the companion branch (with intentional README/replay path updates). uv run --frozen pytest -q tests/unit/test_config/test_observability_settings.py tests/unit/test_core/test_observability tests/unit/test_core/test_lifespan/test_tracing_lifespan.py tests/unit/test_service/test_memorize_span.py: 53 passed. Existing PR CI is green.

@@ -1,135 +0,0 @@
# EverOS × Langfuse (native OpenTelemetry)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The companion migration must be merged before this deletion, otherwise main loses the documented runnable Langfuse integration while the replacement remains unavailable.

EverMind-AI/plugins#10 has not landed and currently reports merge conflicts, while plugins main has no langfuse/ directory. Merging this deletion first therefore makes the replay, live demo, and recording fixture unavailable to users of released EverOS, instead of moving them. Please make the replacement available before removing this source.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two more things before this goes in:

1. Langfuse's official docs link here. The EverOS integration page on langfuse.com (https://langfuse.com/integrations/other/everos) points to this directory in four places:

  • the span/score reference (examples/langfuse/README.md)
  • the recording + replay script (examples/langfuse/)
  • the live demo instructions (python demo.py # from examples/langfuse/)
  • the Resources list

Deleting the directory breaks all four. Their page also relies on our README as the reference for span and score names. So we need to either get the Langfuse docs updated, or keep a README here (see below).

2. Keep a lightweight example entry point in the main repo. Users usually find use cases through the main EverOS repo, and many don't know the plugins repo exists. My suggestion:

  • Keep examples/langfuse/README.md here: what the integration does, setup, the span/score reference, and a link to the full example in EverMind-AI/plugins/langfuse.
  • Move the runnable scripts (.py) and the recording fixtures (.json) to the plugins repo.

That keeps the main repo light and the use case discoverable. The Langfuse links keep working too, except the demo.py command, which we'd ask them to update to the new path.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants