Repository navigation
[GoodBounty-Patch] Connect-a-wallet widget: follow-up fixes and testing #245
Description
Summary
Resolve the five focused items below on the existing Connect-a-wallet widget PR #116, verify its main user flows, and prepare the changes for review.
This is a follow-up bounty, not a new widget implementation.
Bounty tier / reward: Common (full-reward, not split)
Target branch: plan/connect-a-wallet-widget
Contributor task
- Apply with an ETA and wait for assignment.
- Start from the latest
plan/connect-a-wallet-widgetbranch and run the widget locally. - Open your follow-up PR against
plan/connect-a-wallet-widget, notmain. - Complete the scoped fixes using existing repository patterns.
- Provide automated test results and manual wallet-flow QA evidence.
- Respond to each copilot comment with the related fix.
Scope checks
1. Chain-specific status reads
- Use chain-specific HTTP providers for status reads on Fuse, Celo and XDC.
- Keep the connected wallet provider for signing.
- Handle disconnected or missing-wallet-provider states safely.
2. Test the main user actions
Follow existing widget testing patterns and keep coverage focused on this widget.
- Test connecting a wallet, checking status for each supported chain, and linking/unlinking an address.
- Assert the resulting UI and status changes, including wallet cancellation and errors.
- Provide manual wallet-flow QA evidence. Clearly distinguish real wallet checks from mocked automated tests.
- Check desktop and mobile usability and provide relevant screenshots or videos.
Broader testing coverage across widgets belongs to a separate bounty.
3. Clarify screenshot and test-output locations
- Align
AGENTS.mdand associated QA/demo documentation:- Root
/test-results/is ignored temporary output. - Curated widget screenshots belong under
tests/widgets/<widget>/test-results/.
- Root
- Preserve the anchored ignore rule and existing screenshot locations.
4. Invalid-address feedback
- Show clear feedback for an invalid address.
- Clear or update the feedback appropriately when the address changes, so stale errors do not remain.
5. Prevent overlapping operations
- Use a simple widget-wide busy guard to prevent overlapping link/unlink actions and address changes during an operation.
- Clear the busy state on success, cancellation and failure.
- Keep the implementation small: no dialog queue or new architecture.
Required commands
pnpm install
pnpm build
pnpm lint
pnpm test:demo tests/widgets/connect-a-wallet-widget
Follow the repository’s documented test setup. If a command fails or cannot run, report the exact blocker and whether it also occurs before your changes.
Link this bounty and PR #116 in the follow-up PR description.
Metadata
Metadata
Assignees
Type
Projects
- Status
Activity
edehvictor commentedon Oct 13, 2026
GM @L03TJ3 ,
I’d like to take this on. I’m an active GoodDollar open-source contributor and have worked on GoodWidget/GoodWallet-related flows before, including implementation cleanup, UI consistency, Storybook/Playwright verification, and reviewer feedback fixes.
I’ll review the requirements carefully, keep the changes scoped, run the needed checks, and provide a clear handoff when done.
Please kindly assign this to me.
ETA: 12-24 hours.
L03TJ3 commentedon Oct 13, 2026
@edehvictor assigned
Godbrand0 commentedon Oct 13, 2026
GM @L03TJ3 i'd like to work on this issue,given my past experience contributing and creating widgets for this repo.
I have reviewed the requirements and I would be able to complete the task at the estimated time.
ETA- 24hrs
L03TJ3 commentedon Oct 13, 2026
@edehvictor Hey, just to note. this is a goodwidget ticket. moving the issue but just making sure you are working on the expected widget. no work is needed in goodsdks
edehvictor commentedon Oct 13, 2026
Yeah, noted @L03TJ3.
edehvictor commentedon Oct 13, 2026
Handoff Comment
Contributor: @edehvictor
PR: #249 (follow-up to #116 for #245)
Commit: 074b547
Fixed
Verified
Evidence
pnpm test:demo tests/widgets/connect-a-wallet-widget --workers=1 --retries=0.Remaining Risks
Select.tsx:7Role type error, reproduced on the unchanged base.Thanks for the guidance. Happy to adjust anything you would prefer handled differently.
fix(connect-a-wallet-widget): harden wallet flows and QA (#245) (#249)
Feature Connect A Wallet Widget (#116)