Skip to content

vertexai: reduce featureonlinestore, deployed_index, and reasoning_engine test scale - #19686

Draft
NA2047 wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
NA2047:speedup-acctest-vertexai-extra
Draft

NA2047 wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
NA2047:speedup-acctest-vertexai-extra

Conversation

@NA2047

@NA2047 NA2047 commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

vertexai: reduce FeatureOnlineStore max_node_count, DeployedIndex max_replica_count, and ReasoningEngine resource limits in acceptance tests

Summary

Speed up and reduce compute cost of vertexai acceptance tests (non-overlapping with #19649):

  • Reduce Bigtable auto_scaling.max_node_count from 2 to 1 (min_node_count = 1) on helper and non-scaling google_vertex_ai_feature_online_store resources across vertex_ai_featureonlinestore_featureview*.tf.tmpl, vertex_ai_featureonlinestore_with_beta_fields_bigtable.tf.tmpl, resource_vertex_ai_feature_online_store_featureview_test.go, and resource_vertex_ai_feature_online_store_test.go (preserving the scaling update test TestAccVertexAIFeatureOnlineStore_updated).
  • Reduce max_replica_count from 2 to 1 (min_replica_count = 1) in vertex_ai_index_endpoint_deployed_index_automatic_resources.tf.tmpl and vertex_ai_index_endpoint_deployed_index_dedicated_resources.tf.tmpl.
  • Reduce deployment_spec.max_instances from 3 to 2 and resource_limits from cpu = "4", memory = "4Gi" to cpu = "2", memory = "2Gi" in vertex_ai_reasoning_engine_full.tf.tmpl.

Changed Files

  • mmv1/templates/terraform/samples/services/vertexai/vertex_ai_featureonlinestore_featureview.tf.tmpl
  • mmv1/templates/terraform/samples/services/vertexai/vertex_ai_featureonlinestore_featureview_cross_project.tf.tmpl
  • mmv1/templates/terraform/samples/services/vertexai/vertex_ai_featureonlinestore_featureview_feature_registry.tf.tmpl
  • mmv1/templates/terraform/samples/services/vertexai/vertex_ai_featureonlinestore_with_beta_fields_bigtable.tf.tmpl
  • mmv1/templates/terraform/samples/services/vertexai/vertex_ai_index_endpoint_deployed_index_automatic_resources.tf.tmpl
  • mmv1/templates/terraform/samples/services/vertexai/vertex_ai_index_endpoint_deployed_index_dedicated_resources.tf.tmpl
  • mmv1/templates/terraform/samples/services/vertexai/vertex_ai_reasoning_engine_full.tf.tmpl
  • mmv1/third_party/terraform/services/vertexai/resource_vertex_ai_feature_online_store_featureview_test.go
  • mmv1/third_party/terraform/services/vertexai/resource_vertex_ai_feature_online_store_test.go

…count, and reasoning engine limits in untouched tests
@modular-magician

modular-magician commented Oct 24, 2026 •

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit f703f10:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 8 files changed, 21 insertions(+), 21 deletions(-)
google-beta provider View Diff 10 files changed, 27 insertions(+), 27 deletions(-)
Open in Cloud Shell View Diff 5 files changed, 7 insertions(+), 7 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
146 122 11 13
Affected Service Packages
  • vertexai

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 13 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccVertexAIFeatureOnlineStoreFeatureviewIamBindingGenerated
  • TestAccVertexAIFeatureOnlineStoreFeatureviewIamMemberGenerated
  • TestAccVertexAIFeatureOnlineStoreFeatureviewIamPolicyGenerated
  • TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureviewCrossProjectExample
  • TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureviewExample
  • TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureviewFeatureRegistryExample
  • TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_featureRegistry_updated
  • TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_updated
  • TestAccVertexAIFeatureOnlineStore_bigtable_full
  • TestAccVertexAIFeatureOnlineStore_bigtable_with_zone
  • TestAccVertexAIIndexEndpointDeployedIndex_vertexAiIndexEndpointDeployedIndexAutomaticResourcesExample
  • TestAccVertexAIIndexEndpointDeployedIndex_vertexAiIndexEndpointDeployedIndexDedicatedResourcesExample
  • TestAccVertexAIReasoningEngine_vertexAiReasoningEngineFullExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Findings Test Name
✅ Log - TestAccVertexAIFeatureOnlineStoreFeatureviewIamBindingGenerated
✅ Log - TestAccVertexAIFeatureOnlineStoreFeatureviewIamMemberGenerated
✅ Log - TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureviewCrossProjectExample
✅ Log - TestAccVertexAIFeatureOnlineStore_bigtable_with_zone
✅ Log - TestAccVertexAIIndexEndpointDeployedIndex_vertexAiIndexEndpointDeployedIndexAutomaticResourcesExample
✅ Log - TestAccVertexAIIndexEndpointDeployedIndex_vertexAiIndexEndpointDeployedIndexDedicatedResourcesExample
✅ Log - TestAccVertexAIReasoningEngine_vertexAiReasoningEngineFullExample
❌ Error · Log 🔴 Nightly passes 100% of 29 TestAccVertexAIFeatureOnlineStoreFeatureviewIamPolicyGenerated
❌ Error · Log 🟡 Nightly flaky fails 14% of 29 TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureviewExample
❌ Error · Log 🔴 Nightly fixed last failed 2026-10-17 TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureviewFeatureRegistryExample
❌ Error · Log 🔴 Nightly fixed last failed 2026-10-16 TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_featureRegistry_updated
❌ Error · Log 🔴 Nightly fixed last failed 2026-10-19 TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_updated
❌ Error · Log ⚪ Nightly fails 28% of 29 TestAccVertexAIFeatureOnlineStore_bigtable_full

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

🟡 Known Nightly Failures: 2 of the tests that failed in recording also fail or are flaky in the last 30 days of nightly runs, so they may be unrelated to this PR. In nightly findings, ⚪ means the test already fails in nightly, 🟡 that it is flaky there, and 🔴 that it is healthy in nightly and so more likely broken by this PR.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@NA2047 VCR tests complete for f703f10!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants