Repository navigation
Create the matching Read node when dropping a Map node onto a wire - #4925
Merged
Merged
Conversation
Co-authored-by: Ankit-cs <172617740+Ankit-cs@users.noreply.github.com> Co-authored-by: shubhtrek <135618936+shubhtrek@users.noreply.github.com>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 3 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4792
Dropping a Map node onto a wire now feeds its mapped input with the Read node matching its content's element type (Vector, Graphic, Raster, Color, Gradient, Number, String). A mapped input that is already wired is left alone, and the Read node is placed below the content source so it doesn't overlap a tall upstream node.
This builds on the approaches from #4812 and #4819, whose authors are credited as co-authors.