Repository navigation
Conversation
kevin9327
requested review from
omerarslan0,
yuh-yang and
zhangxilong-43
as code owners
October 20, 2026 03:13
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
github-actions
Bot
added
the
existing-cli-fix
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
timecode_to_secondsin the kdenlive harness (behindparse_time, which the CLI uses for clip in/out points and similar times) triedfloat(tc)first and returned whatever came back. So"-5","nan"and"inf"were accepted as timeline positions and written into the project, even thoughseconds_to_timecodein the same module already rejects negative seconds.Fix: after the
float()fast path, raiseValueErrorfor non-finite or negative values. TheHH:MM:SS.mmmpath can't produce these and is unchanged.Test:
test_timecode_to_seconds_rejects_negative_and_non_finite(5 cases) inkdenlive/agent-harness/cli_anything/kdenlive/tests/test_core.pyfails before and passes after. All 116 tests in that file pass.AI-assistance note: I found and wrote this change with help from an AI coding assistant. I reviewed it and ran the tests myself.