Skip to content

Fix STRETCH live preview, reference snapping, Shift vertex exclusion and release build - #1962

Merged
gianlucafiore merged 23 commits into
HakanSeven12:mainfrom
gianlucafiore:fix/stretch-preview-shift-points-build-20261020
Oct 20, 2026
Merged

Fix STRETCH live preview, reference snapping, Shift vertex exclusion and release build#1962
gianlucafiore merged 23 commits into
HakanSeven12:mainfrom
gianlucafiore:fix/stretch-preview-shift-points-build-20261020

Conversation

@gianlucafiore

@gianlucafiore gianlucafiore commented Oct 20, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Restore the live STRETCH entity preview throughout normal cursor movement and the optimized fast-pointer path, without changing the general snapping/performance pipeline.
  • Keep the original geometry visible as a lighter, translucent, stationary ghost while the stretched result follows the cursor. Allow discrete snaps to the original (endpoints, midpoints, centers, etc.) consistently during movement and the final point pick; exclude continuous self-snapping to the moving preview.
  • Support Shift+click to remove individual selected STRETCH vertices during crossing-window selection. Preserve these exclusions across command relaunch, the preview, the final edit, and parametric-reference handling.
  • Fix the non-test/release compilation error in src/scene/block_actions.rs: create_with_frame now calls the production-available create_with_frame_points instead of the #[cfg(test)] helper create_with_options.
  • Ensure instanced/block geometry in previews is uploaded and drawn by the appropriate GPU pipeline.

Verification

  • Contributor reports local build, manual behavior checks, and requested tests passing before opening this PR.
  • Added regression tests for STRETCH cursor-move preview (including the fast path) and Shift-excluded vertices.
  • No changes to the optimized resident-drawing snap engine or broader performance behavior.

Scope

Single branch containing the related small build fix and STRETCH interaction/preview corrections.

@gianlucafiore
fix(block-actions): use production creator for frame actions
9f6d9fe
@gianlucafiore
feat(stretch): carry Shift-excluded vertices across selection and commit
ce7c500
@gianlucafiore
feat(stretch): exclude selected vertices from preview and edit with S…
bdbf6fb 
…hift
@gianlucafiore
feat(stretch): route excluded vertices through command results
1107a3f
@gianlucafiore
feat(stretch): preserve Shift-removed points through preview and commit
eb1afd8
@gianlucafiore
feat(stretch): expose consumed vertex-removal release
fb26e1b
@gianlucafiore
feat(stretch): suppress point pick after Shift-removal gesture
613e898
@gianlucafiore
feat(stretch): Shift+click to subtract an individual selected vertex
93f4aed
@gianlucafiore
fix(preview): draw instanced STRETCH and grip previews
195c5d0
@gianlucafiore
fix(preview): use full overlay when live STRETCH contains block insta…
8526dc5 
…nces
@gianlucafiore
test(stretch): Shift-excluded endpoints persist and do not move
e37ef59
@gianlucafiore
fix(stretch): preserve full precision in live rubber-band guide
b5f71c4
@gianlucafiore
fix(stretch): include edited geometry in cursor-move live preview
dbe56ec
@gianlucafiore
fix(stretch): update edited-entity overlay in capped fast pointer path
520bdf4
@gianlucafiore
test(stretch): keep edited lines in full and fast cursor previews
d7ad4cc
@gianlucafiore
feat(commands): expose stationary snap references for replacement pre…
df46bf8 
…views
@gianlucafiore
feat(stretch): show fixed faded original geometry under moving preview
5d18ea4
@gianlucafiore
feat(stretch): snap to fixed original ghost during hover, fast move a…
cfc5ebc 
…nd commit
@gianlucafiore
feat(stretch): distinguish Shift subtraction windows in selection result
a53ab93
@gianlucafiore
feat(stretch): latch Shift at first box corner and emit subtraction w…
444f127 
…indow
@gianlucafiore
feat(stretch): route Shift subtraction box through command driver
c4c6a2b
@gianlucafiore
feat(stretch): exclude selected grips inside Shift box, preserving en…
49c6366 
…tity selection
@gianlucafiore
test(stretch): Shift box subtracts points without expanding crossing …
0b76a69 
…selection
@gianlucafiore
gianlucafiore merged commit 4b8b778 into HakanSeven12:main Oct 20, 2026
2 of 6 checks passed
HakanSeven12 added a commit that referenced this pull request Oct 20, 2026
@HakanSeven12 @claude
Review fixes for #1962
c12076c 
- One is_excluded helper for Shift-removed STRETCH vertices; the five
  hand-copied 1e-9 comparisons in transform.rs and stretch.rs use it, and
  stretch_entity_except takes the (handle, point) list directly instead of
  each caller filtering it into a temporary Vec.
- The Shift subtraction window prompt was an untranslated literal; it
  reuses the existing translated opposite-corner prompt.
- Viewport: no command-name checks. The move path always adds
  preview_entities (empty for every command but STRETCH, as the structure
  and dwell paths already do), the capped fast path refreshes for any
  command that hides its sources, and Shift+grip removal is offered to
  the active command, which declines unless it is STRETCH.
- Hand-wrapped the lines the PR left over 100 columns or unformatted.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
HakanSeven12 added a commit that referenced this pull request Oct 20, 2026
@HakanSeven12
Merge branch 'review/1962' (review fixes for #1962, #1952)
1207110
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@gianlucafiore