Skip to content

Check test-bot dependencies recursively - #23981

Merged
MikeMcQuaid merged 1 commit into
mainfrom
test-bot-recursive-dependencies
Sep 15, 2026
Merged

MikeMcQuaid merged 1 commit into
mainfrom
test-bot-recursive-dependencies

Conversation

@MikeMcQuaid

Copy link
Copy Markdown
Member
  • Check recursive runtime dependencies before building bottles, since an existing bottle can outlive its dependencies' bottle support.
  • Keep accepting dependencies built in the current run and compatible older bottles where permitted.

Fixes #23963


  • Have you followed our Contributing guidelines?
  • Have you checked for other open Pull Requests for the same change?
  • Have you explained what your changes do? Performance claims (e.g. "this is faster") must include brew benchmark results.
  • Have you explained why you'd like these changes included, not just what they do?
  • For bug fixes, have you given step-by-step brew commands to reproduce the bug?
  • Have you written new tests (excluding integration tests)? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) locally?

  • I did not use AI/LLM to create this PR, or I disclosed the tool/model below and reviewed its output; I did not attribute commits to AI and will answer maintainer questions and review comments myself without AI/LLM.

Codex with GPT 6 Astra at Extra High effort, with local review and testing.


Copilot AI balanced review requested due to automatic review settings September 15, 2026 16:36

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃煝 Approval recommended

No unresolved review issues were identified.

Pull request overview

Updates Test Bot to validate recursive runtime dependencies before building bottles.

Changes:

  • Checks recursive dependency bottle eligibility.
  • Preserves current-run builds and compatible older bottles.
  • Adds regression coverage.
File summaries
File Description
Library/Homebrew/test/test_bot/test_formulae_spec.rb Adds tests for recursive dependency scenarios.
Library/Homebrew/test_bot/test_formulae.rb Implements recursive runtime dependency checks.
Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 0
  • Review effort level: Lite (auto)

Note

Copilot is running an experiment and ran this review at Lite.


馃挕 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

- Check recursive runtime dependencies before building bottles, since
  an existing bottle can outlive its dependencies' bottle support.
- Keep accepting dependencies built in the current run and compatible
  older bottles where permitted.
- Model bottle compatibility in tests independently of the host OS.

Fixes #23963
@MikeMcQuaid
MikeMcQuaid force-pushed the test-bot-recursive-dependencies branch from 05bf2f1 to 4202f49 Compare September 15, 2026 16:52
@MikeMcQuaid
MikeMcQuaid added this pull request to the merge queue Sep 15, 2026
Merged via the queue into main with commit e05da90 Sep 15, 2026
51 checks passed
@MikeMcQuaid
MikeMcQuaid deleted the test-bot-recursive-dependencies branch September 15, 2026 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Check for Unbottled Dependencies doesn't Recursively Check Dependencies

3 participants