Repository navigation
Check test-bot dependencies recursively - #23981
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
馃煝 Approval recommended
No unresolved review issues were identified.
Pull request overview
Updates Test Bot to validate recursive runtime dependencies before building bottles.
Changes:
- Checks recursive dependency bottle eligibility.
- Preserves current-run builds and compatible older bottles.
- Adds regression coverage.
File summaries
| File | Description |
|---|---|
Library/Homebrew/test/test_bot/test_formulae_spec.rb |
Adds tests for recursive dependency scenarios. |
Library/Homebrew/test_bot/test_formulae.rb |
Implements recursive runtime dependency checks. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite (auto)
Note
Copilot is running an experiment and ran this review at Lite.
馃挕 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
- Check recursive runtime dependencies before building bottles, since an existing bottle can outlive its dependencies' bottle support. - Keep accepting dependencies built in the current run and compatible older bottles where permitted. - Model bottle compatibility in tests independently of the host OS. Fixes #23963
MikeMcQuaid
force-pushed
the
test-bot-recursive-dependencies
branch
from
September 15, 2026 16:52
05bf2f1 to
4202f49
Compare
krehel
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23963
brew benchmarkresults.brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?Codex with GPT 6 Astra at Extra High effort, with local review and testing.