Repository navigation
Fix CLT version check on Intel Tahoe - #24043
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Intel macOS 26,
brew doctorreports CLT 26.6 as outdated even though it is the latest compatible release. The check requires clang2100.3.34.2, but CLT 26.6 provides2100.1.1.101.Use the CLT 26.6 threshold on Intel macOS 26. The existing
physical_cpu_arm64?helper keeps the newer threshold on Apple Silicon, including under Rosetta. macOS 27 keeps its current threshold, and older Intel CLTs still trigger the warning.Fixes #24041.
To reproduce on an Intel Mac running macOS 26 with CLT 26.6 installed:
brew doctor check_clt_up_to_datebefore applying the patch.A newer Command Line Tools release is available.disappears.Validation:
pkgutil --check-signaturereportedsigned Apple Software; the extractedPackageInfoidentifiescom.apple.pkg.CLTools_Executablesversion26.6.0.0.1781586589. Running the extractedclang --versionon arm64 and viaarch -x86_64returnedclang-2100.1.1.101in both cases. The package was extracted to a temporary directory, not installed../bin/brew tests --only=os/mac/xcode:54,os/mac/xcode:62,os/mac/xcode:76,os/mac/xcode:82,os/mac/xcode:88../bin/brew lgtm --onlinepassed: type checking, style and all 12 examples in the affected spec on the development machine.I also checked the threshold before and after the patch on an Intel MacBook running Ventura 13.6, in a separate clone. This command simulates macOS 26.7 inside the Ruby process and uses the Mac's real CPU:
HOMEBREW_NO_AUTO_UPDATE=1 ./bin/brew ruby -- -e 'require "os/mac/xcode"; MacOS.full_version = "26.7"; puts MacOS::CLT.latest_clang_version'14c54f7c762100.3.34.22100.1.1.101Note
My Intel Mac runs Ventura 13.6, and I need to keep its macOS and Homebrew installation unchanged. I tested in a separate clone, simulating macOS 26.7 within the Ruby process. RSpec was blocked by native gem compilation failures. I have not tested the full setup on Intel with macOS 26 and CLT 26.6 installed.
brew benchmarkresults.brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?I used OpenAI Codex (GPT-6) to investigate the issue, draft the patch, tests and this description, verify the Apple package and run the automated checks. I ran the Intel before/after check and reviewed the code and this description.