Repository navigation
dev-cmd/advisory-match: fix test style - #24076
Merged
Merged
Conversation
The "holds differing platform histories" example in dev-cmd/advisory-match_spec.rb passes `brew style` but produces an error when the test is run by `brew tests`: "/opt/homebrew/Library/ Homebrew/test/dev-cmd/advisory-match_spec.rb:496: warning: mismatched indentations at 'end' with 'else' at 494". This resolves the issue by restructuring the related keyword arguments in a way that resolves this message, still passes `brew style`, and is more readable to people looking at this code (especially in an editor wrapping to 80 characters per line).
Contributor
There was a problem hiding this comment.
Copilot review overview
馃煝 Approval recommended
The formatting-only change resolves the warning without altering behavior.
Review effort: Lite
Findings: None
What changed in this PR
This pull request fixes a mismatched-indentation warning in the advisory-match test while preserving behavior.
Changes:
- Reformats
ReconciledHistorykeyword arguments. - Clarifies the platform-specific
fixedvalue expression.
| File | Description |
|---|---|
Library/鈥婬omebrew/鈥媡est/鈥媎ev-cmd/鈥媋dvisory-match_spec.rb |
Reformats the affected test setup. |
馃挕 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
krehel
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew benchmarkresults.brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?The "holds differing platform histories" example in dev-cmd/advisory-match_spec.rb passes
brew stylebut produces an error when the test is run bybrew tests: "/opt/homebrew/Library/ Homebrew/test/dev-cmd/advisory-match_spec.rb:496: warning: mismatched indentations at 'end' with 'else' at 494". This resolves the issue by restructuring the related keyword arguments in a way that resolves this message, still passesbrew style, and is more readable to people looking at this code (especially in an editor wrapping to 80 characters per line).I noticed this when running
brew teststo test unrelated changes, so I figured I would take a moment to address it.