Skip to content

Stabilise warning and GitHub artifact tests - #24093

Merged
MikeMcQuaid merged 1 commit into
mainfrom
reset-auditing-between-tests
Sep 25, 2026
Merged

MikeMcQuaid merged 1 commit into
mainfrom
reset-auditing-between-tests

Conversation

@MikeMcQuaid

@MikeMcQuaid MikeMcQuaid commented Sep 25, 2026 •

Copy link
Copy Markdown
Member
  • Reset Homebrew.auditing so audit tests cannot suppress warnings.
  • Stub artifact responses so URL tests survive GitHub artifact expiry.

  • Have you followed our Contributing guidelines?
  • Have you checked for other open Pull Requests for the same change?
  • Have you explained what your changes do? Performance claims (e.g. "this is faster") must include brew benchmark results.
  • Have you explained why you'd like these changes included, not just what they do?
  • For bug fixes, have you given step-by-step brew commands to reproduce the bug?
  • Have you written new tests (excluding integration tests)? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) locally?

  • I did not use AI/LLM to create this PR, or I disclosed the tool/model below and reviewed its output; I did not attribute commits to AI and will answer maintainer questions and review comments myself without AI/LLM.

Codex with GPT 6 Astra at Extra High effort, with local review and testing.


Copilot AI lite review requested due to automatic review settings September 25, 2026 21:26

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

馃煝 Approval recommended

No unresolved review issues were identified.

Review effort: Lite
Findings: None

What changed in this PR

Resets auditing state between tests to prevent audit examples from suppressing later deprecation warnings.

Changes:

  • Sets Homebrew.auditing to false in shared test setup.
File Description
Library/鈥婬omebrew/鈥媡est/鈥媠pec_helper.rb Resets auditing state between examples.

馃挕 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

- Reset `Homebrew.auditing` so audit tests cannot suppress warnings.
- Stub artifact responses so URL tests survive GitHub artifact expiry.
@MikeMcQuaid
MikeMcQuaid force-pushed the reset-auditing-between-tests branch from 13222d4 to 08755e5 Compare September 25, 2026 21:59
@MikeMcQuaid MikeMcQuaid changed the title Reset auditing state between tests Stabilise warning and GitHub artifact tests Sep 25, 2026
@MikeMcQuaid
MikeMcQuaid added this pull request to the merge queue Sep 25, 2026
Merged via the queue into main with commit 81fd723 Sep 25, 2026
52 checks passed
@MikeMcQuaid
MikeMcQuaid deleted the reset-auditing-between-tests branch September 25, 2026 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants