Repository navigation
Stabilise warning and GitHub artifact tests - #24093
Merged
Merged
Conversation
dduugg
approved these changes
Sep 25, 2026
krehel
approved these changes
Sep 25, 2026
Contributor
There was a problem hiding this comment.
Copilot review overview
馃煝 Approval recommended
No unresolved review issues were identified.
Review effort: Lite
Findings: None
What changed in this PR
Resets auditing state between tests to prevent audit examples from suppressing later deprecation warnings.
Changes:
- Sets
Homebrew.auditingtofalsein shared test setup.
| File | Description |
|---|---|
Library/鈥婬omebrew/鈥媡est/鈥媠pec_helper.rb |
Resets auditing state between examples. |
馃挕 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
- Reset `Homebrew.auditing` so audit tests cannot suppress warnings. - Stub artifact responses so URL tests survive GitHub artifact expiry.
MikeMcQuaid
force-pushed
the
reset-auditing-between-tests
branch
from
September 25, 2026 21:59
13222d4 to
08755e5
Compare
MikeMcQuaid
enabled auto-merge
September 25, 2026 22:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Homebrew.auditingso audit tests cannot suppress warnings.brew benchmarkresults.brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?Codex with GPT 6 Astra at Extra High effort, with local review and testing.