Skip to content

dev-cmd/bump-formula-pr: append patch checkbox to formula_checkboxes - #24122

Merged
MikeMcQuaid merged 1 commit into
mainfrom
patches-checkbox-fix
Sep 29, 2026
Merged

MikeMcQuaid merged 1 commit into
mainfrom
patches-checkbox-fix

Conversation

@botantony

Copy link
Copy Markdown
Member

If PR message contains patch and other checkboxes it adds unnecessary newlines between them. Fix it by appending patch checkbox to formula_checkboxes and not formula_pr_message

Example: Homebrew/homebrew-core#314265


  • Have you followed our Contributing guidelines?
  • Have you checked for other open Pull Requests for the same change?
  • Have you explained what your changes do? Performance claims (e.g. "this is faster") must include brew benchmark results.
  • Have you explained why you'd like these changes included, not just what they do?
  • For bug fixes, have you given step-by-step brew commands to reproduce the bug?
  • Have you written new tests (excluding integration tests)? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) locally?

  • I did not use AI/LLM to create this PR, or I disclosed the tool/model below and reviewed its output; I did not attribute commits to AI and will answer maintainer questions and review comments myself without AI/LLM.

If PR message contains `patch` and other checkboxes it adds unnecessary
newlines between them. Fix it by appending `patch` checkbox to
`formula_checkboxes` and not `formula_pr_message`

Example: Homebrew/homebrew-core#314265

Signed-off-by: botantony <antonsm21@gmail.com>
Copilot AI lite review requested due to automatic review settings September 29, 2026 16:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

馃煛 Changes recommended

Add focused regression coverage for combined checkbox output.

Review effort: Lite
Findings: 1 Low severity

Open (1)
What changed in this PR

Updates bump-formula-pr to group the patch checkbox with other formula checkboxes, avoiding unnecessary blank lines.

Changes:

  • Collects the patch checkbox in the shared checkbox list.
  • Preserves unified checkbox formatting.
File Description
Library/鈥婬omebrew/鈥媎ev-cmd/鈥媌ump-formula-pr.rb Consolidates generated formula checkboxes; regression coverage should verify adjacent patch and resource/TODO checkbox output.

馃挕 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Comment thread Library/Homebrew/dev-cmd/bump-formula-pr.rb

@MikeMcQuaid MikeMcQuaid left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense thanks!

@MikeMcQuaid
MikeMcQuaid added this pull request to the merge queue Sep 29, 2026
Merged via the queue into main with commit 19e9e67 Sep 29, 2026
54 checks passed
@MikeMcQuaid
MikeMcQuaid deleted the patches-checkbox-fix branch September 29, 2026 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants