Repository navigation
sandbox: allow system trust evaluation online - #24126
Merged
Merged
Conversation
- Allow `com.apple.trustd` for TLS trust evaluation in online builds. - Keep it denied offline, including with local socket exceptions, because trust evaluation can fetch certificates and revocation data. - Cover the online allowance and offline restrictions with tests. Fixes #24124
carlocab
approved these changes
Sep 29, 2026
p-linnane
approved these changes
Sep 29, 2026
Contributor
There was a problem hiding this comment.
Copilot review overview
馃煝 Approval recommended
No unresolved review comments; the changes and tests cover the stated behavior.
Review effort: Lite
Findings: None
What changed in this PR
Enables com.apple.trustd for macOS online sandboxed builds while preserving offline restrictions.
Changes:
- Conditionally permits trust daemon access when networking is enabled.
- Adds tests for online access and offline/socket-exception restrictions.
| File | Description |
|---|---|
Library/鈥婬omebrew/鈥媡est/鈥媠andbox_spec.rb |
Tests online and offline trust evaluation behavior. |
Library/鈥婬omebrew/鈥媏xtend/鈥媜s/鈥媘ac/鈥媠andbox.rb |
Adds conditional trust daemon access. |
馃挕 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
com.apple.trustdfor TLS trust evaluation in online builds.Fixes #24124
brew benchmarkresults.brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?Codex with GPT 6 Astra at Medium effort, with local review and testing.