Repository navigation
bump: use refresh_for_tag for per-OS detection - #24127
Merged
Merged
Conversation
- Casks with macOS-version blocks such as `cd-to` have no `version` when evaluated on Linux, so a bare `CaskLoader.load` raised `CaskInvalidError`and aborted the whole `brew bump --auto` autobump run. - `refresh_for_tag` already returns `nil` for tags a cask cannot be evaluated for, which falls back to arch-only resolution as before.
p-linnane
approved these changes
Sep 29, 2026
MikeMcQuaid
enabled auto-merge
September 29, 2026 18:28
Contributor
There was a problem hiding this comment.
Copilot review overview
馃煛 Changes recommended
The initial cask load can still fail before platform-aware refreshing, and the test does not exercise that Linux path.
Review effort: Lite
Findings: 1
What changed in this PR
Updates brew bump to use refresh_for_tag for platform-specific cask version detection and adds regression coverage.
Changes:
- Refreshes casks per OS and architecture tag.
- Adds coverage for macOS-only version blocks.
| File | Description |
|---|---|
Library/鈥婬omebrew/鈥媡est/鈥媎ev-cmd/鈥媌ump_spec.rb |
Adds regression tests for platform-specific cask resolution. |
Library/鈥婬omebrew/鈥媎ev-cmd/鈥媌ump.rb |
Updates per-OS cask version detection. |
馃挕 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
bevanjkay
approved these changes
Sep 29, 2026
4 of 7 tasks
Contributor
|
Apologies for introducing this bug! 馃槼 馃檱 Any tips for avoiding similar issues with future contributions? Note that I can only test locally on Linux. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cd-tohave noversionwhen evaluated on Linux, so a bareCaskLoader.loadraisedCaskInvalidErrorand aborted the wholebrew bump --autoautobump run.refresh_for_tagalready returnsnilfor tags a cask cannot be evaluated for, which falls back to arch-only resolution as before.This should fix Cask autobump failures that appear to have been accidentally introduced in #24111.
See: https://github.com/Homebrew/homebrew-cask/actions/runs/36591168962
brew benchmarkresults.brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?Fable 5 Max with manual review,
brew lgtm --online.