Repository navigation
test/formula_spec: mock cached_download to avoid slow test - #24171
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
馃煝 Approval recommended
No unresolved review comments remain.
Review effort: Lite
Findings: None
What changed in this PR
Updates formula_spec to avoid slow download resolution in std_go_args tests.
Changes:
- Uses a realistic tarball URL.
- Mocks cached downloads and Git metadata lookups.
- Preserves coverage for revision and repository cases.
| File | Description |
|---|---|
Library/鈥婬omebrew/鈥媡est/鈥媐ormula_spec.rb |
Speeds up tests with deterministic download mocks. |
馃挕 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
carlocab
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I applied a Copilot suggestion back in prior PR to use
cached_downloadbut this causes slowdown in tests when download doesn't exist. I think it tries to access url via curl to resolve filename from headers.So mock a value to avoid increasing testcase time.
Prior to this,
brew tests --only formula --profile 5would have 3 of these hit 7+ seconds making them significantly slower than rest. After changes, these no longer show up in slowest tests.brew benchmarkresults.brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?n/a