Repository navigation
Document yearly BottleTransition update - #24243
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BottleTransitionkeeps existing bottles while a new macOS release is bootstrapped. Its comment had aTODOto remove the class onceHOMEBREW_MACOS_NEWEST_SUPPORTEDis27.In #24237 I removed it, but the review asked to keep it. It prevented us from losing bottles during this year's transition, and we need the same protection for future macOS releases.
This change replaces the
TODOwith instructions for updatingMACOSeach year. It also notes thattest/bottle_transition_spec.rbuses release symbols directly, so they need the same update.No behaviour change. Only the comment changes.
brew benchmarkresults.brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?AI (Claude Code) summarised the review and drafted the new comment. I reviewed the wording and ran
brew lgtmlocally.