Repository navigation
cask/audit: skip resource-only bundles - #24247
Merged
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📜 Recent review details
📝 Summary
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Title check |  |
The title clearly and concisely describes the main change: skipping resource-only bundles during cask auditing. |
| Description check | |
The description directly explains the false Gatekeeper failure fix, preserves checks for relevant bundles, and identifies the related issue and tests. |
| Linked Issues check | |
The PR meets issue #24246. audit_signing skips .bundle directories that have no Contents/Info.plist or Info.plist and no assessable native code. It still searches for executable, dylib, and Ma… |
| Out of Scope Changes check | |
The changes stay within issue #24246. Production changes are limited to cask signing-audit bundle detection. The added tests verify the required skip and preserve behavior. No unrelated production beh… |
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
- Configuration used: Organization UI
- Review profile: CHILL
- Plan: Advanced
- Run ID:
10268e64-c4ef-4271-a7ed-1a7367a8135f
📒 Files selected for processing: 2
Library/Homebrew/cask/audit.rbLibrary/Homebrew/test/cask/audit_spec.rb
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.
📜 Review details
⏰ Context from checks skipped due to timeout: 19
- GitHub Check: docker (x86_64 Ubuntu 26.04)
- GitHub Check: docker (arm64 Ubuntu 24.04)
- GitHub Check: docker (x86_64 Ubuntu 24.04)
- GitHub Check: docker (arm64 Ubuntu 26.04)
- GitHub Check: docs
- GitHub Check: tests (generic OS, 2/2)
- GitHub Check: tests (online, 1/2)
- GitHub Check: tests (macOS, 1/2)
- GitHub Check: tests (macOS, 2/2)
- GitHub Check: tests (load-only macOS)
- GitHub Check: tests (online, 2/2)
- GitHub Check: tests (load-only Linux)
- GitHub Check: tests (generic OS, 1/2)
- GitHub Check: tests (no Sorbet)
- GitHub Check: tests (Linux, 1/2)
- GitHub Check: tests (Linux, 2/2)
- GitHub Check: syntax
- GitHub Check: workflow_syntax
- GitHub Check: Analyze
- Avoid false Gatekeeper failures for localisation resources. - Preserve checks for bundles with metadata or native code. - Assess nested bundles separately from their resource-only parents. Fixes #24246
MikeMcQuaid
force-pushed
the
cask-audit-resource-bundles
branch
from
October 13, 2026 19:51
f9c62f6 to
574f86e
Compare
MikeMcQuaid
enabled auto-merge
October 13, 2026 19:56
krehel
approved these changes
Oct 13, 2026
Member
|
Thanks for fixing this one @MikeMcQuaid |
This was referenced Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #24246
brew benchmarkresults.brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?Codex with GPT 6 Astra at Extra High effort, with local review and testing.