Repository navigation
shared_audits: parse whois dates with spaces - #24276
Merged
Merged
Conversation
- DNS Belgium's `whois` prints `Registered: Fri Jan 18 2013`, so capturing only `\S+` passed `Fri` to `Date.parse`, which resolves it to the current week's Friday and flagged long-registered `.be` domains as new.
carlocab
approved these changes
Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
whoisprintsRegistered: Fri Jan 18 2013, so capturing only\S+passedFritoDate.parse, which resolves it to the current week's Friday and flagged long-registered.bedomains as new.Discovered in Homebrew/homebrew-cask#294489
brew benchmarkresults.brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?Claude with Opus 5.5 at Extra High effort, with local review and testing.
Summary by CodeRabbit