Repository navigation
Conversation
github-actions
Bot
added
type:Bug
hjmjohnson
marked this pull request as ready for review
June 17, 2026 20:48
This comment was marked as resolved.
This comment was marked as resolved.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
hjmjohnson
force-pushed
the
dcmtk-series-geometric-ordering
branch
from
June 17, 2026 21:02
f2c3bc0 to
76f7eff
Compare
Member
Author
|
@dzenanz @thewtex This PR needs to be reviewed, and finalized before the next two DCMTK PR's can pass. The DCMTK series handling needed to be made more like GDCM to ensure tests were consistent across both GDCM and DCMTK. Derivatives of the test infrastructure are part of completing a long outstanding #2735 bad behaviors. |
The geometric slice ordering (added via PR InsightSoftwareConsortium#6456 for issue InsightSoftwareConsortium#6463) derived the slice normal from headers.front() alone. If the first file returned by the directory glob lacks ImageOrientationPatient (e.g. a localizer or a corrupt slice that sorted first), geometric ordering was silently suppressed for the entire series. Scan for the first slice carrying a valid orientation instead. Also correct the regression-test comment to cite issue InsightSoftwareConsortium#6463 rather than the downstream PR InsightSoftwareConsortium#6456. Addresses the greptile review on PR InsightSoftwareConsortium#6464.
hjmjohnson
force-pushed
the
dcmtk-series-geometric-ordering
branch
from
June 18, 2026 00:35
76f7eff to
9169745
Compare
github-actions
Bot
removed
the
type:Infrastructure
hjmjohnson
changed the title
Member
Author
|
Sorry, I tried to split a branch with several commits into two PRs, then they diverged a bit. |
Member
Author
|
Status update — rebased onto current The core ordering fix originally in this PR ( What this PR now is (net +14/−3, 2 files)
Was |
dzenanz
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Robustness follow-up to the DCMTKSeriesFileNames geometric ordering: derive the slice normal from the first slice that actually carries an ImageOrientationPatient, not just the first globbed file.
What remains in this PR
itkDCMTKSeriesFileNames.cxx— scan for the first slice with a valid orientation before computing the slice normal; a single mis-globbed entry withoutImageOrientationPatient(e.g. a localizer that sorted first) no longer suppresses geometric ordering for the whole series.itkDCMTKSeriesFileNamesOrderingGTest.cxx— comment now cites issue itk::DCMTKSeriesFileNames orders slices by InstanceNumber only, not geometrically like GDCMSeriesFileNames #6463 instead of the downstream PR COMP: Switch IOTransformDCMTK test from GDCMImageIO to DCMTKImageIO #6456.Net diff vs
main: 2 files, +14/−3. The ordering GTest passes;pre-commit run --all-filesis clean.