[hjmjohnson]

Four Core/Common GoogleTests printed an error when a check failed but did not fail the test. One BUG: commit per test turns each into a real check.

Test	Check	Fix
itkSTLContainerAdaptorGTest	both containers end together (4 sites)	return EXIT_FAILURE, like the helper's other checks
itkCovariantVectorGTest	component bytes match a double	EXPECT_EQ
itkThreadedIndexedContainerPartitionerGTest	work units capped by the range	EXPECT_EQ
itkVersorGTest	computed rotation matrix is orthogonal	EXPECT_TRUE(is_identity(...))

Testing

macOS arm64, conda clang, Release, Module_ITKCommon=ON. Every commit builds ITKCommonGTestDriver with 0 warnings, and the five affected tests pass, so none of these checks was hiding a failure. The partitioner check runs only with more than one thread; it ran here. pre-commit run --all-files passes.

How these were found

A scan of every GoogleTest on main for error branches that cannot fail the test, done alongside #7046 and #7048. Each pattern was copied faithfully from the legacy test when it was converted.

AI assistance (Claude Code) was used to find the defects and draft the changes; they were reviewed and tested locally.

[greptile-apps]

Confidence Score: 5/5

[Low impact] This PR appears safe to merge.

Summary

This PR makes four Core/Common GoogleTest files fail checks that previously only printed errors.

• The STL adaptor test fails when paired iterators end at different times.
• The covariant-vector test fails when a component byte differs from a double.
• The partitioner test fails when a short range uses the wrong number of work units.
• The versor test fails when a computed rotation matrix is not orthogonal.

No actionable issues were found. Review was based on source inspection; no tests were run during this review.

_{Reviews (1) · Last reviewed commit: "BUG: Fail Versor test when a computed ro..." · Reviewed by Greptile}