Skip to content

Wait for every build before testing - #412

Open
jharlow-intel wants to merge 1 commit into
masterfrom
ci/tests-wait-all-builds
Open

jharlow-intel wants to merge 1 commit into
masterfrom
ci/tests-wait-all-builds

Conversation

@jharlow-intel

Copy link
Copy Markdown
Contributor

The test and test-wheel jobs in intel-ci.yml now need both build jobs, build and build-wheel. Until now each one waited only for its own build job, so a failed wheel build still started the conda package tests, and a failed conda build still started the wheel tests.

A failed build already fails the run, so no test runners start for a run that can't go green, and they stay free for other runs in the queue. On a green run the tests start once both sets of builds have finished.

Validation: zizmor and pre-commit pass on the workflow. This pull request's own run exercises the green path; the failed-build path follows from how needs works and was not run.

The test jobs for the conda packages and the wheels now need both build jobs, so a run with any failed build starts no test runners.
@jharlow-intel jharlow-intel self-assigned this Nov 20, 2026
Copilot AI balanced review requested due to automatic review settings November 20, 2026 20:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the change that makes both Intel CI test jobs depend on both build matrices.

No open issues 🎉

What changed in this PR

This PR makes the conda and wheel test jobs in Intel CI wait for both build matrices, avoiding post-build test runner use when either build matrix fails.

Changes:

  • Add both build and build-wheel as dependencies of test and test-wheel.
  • Preserve both test families on successful runs, starting them only after both build matrices succeed.

The root AGENTS.md was not found, so further repository inspection was stopped.

File Description
.github/​workflows/​intel-ci.yml Adds a shared build dependency gate to both post-build test jobs.

Review effort: Balanced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants