Repository navigation
Wait for every build before testing - #412
Open
jharlow-intel wants to merge 1 commit into
Open
jharlow-intel wants to merge 1 commit into
jharlow-intel wants to merge 1 commit into
Conversation
The test jobs for the conda packages and the wheels now need both build jobs, so a run with any failed build starts no test runners.
jharlow-intel
requested review from
antonwolfy,
ndgrigorian,
vlad-perevezentsev and
xaleryb
as code owners
November 20, 2026 20:41
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the change that makes both Intel CI test jobs depend on both build matrices.
No open issues 🎉
What changed in this PR
This PR makes the conda and wheel test jobs in Intel CI wait for both build matrices, avoiding post-build test runner use when either build matrix fails.
Changes:
- Add both
buildandbuild-wheelas dependencies oftestandtest-wheel. - Preserve both test families on successful runs, starting them only after both build matrices succeed.
The root AGENTS.md was not found, so further repository inspection was stopped.
| File | Description |
|---|---|
.github/workflows/intel-ci.yml |
Adds a shared build dependency gate to both post-build test jobs. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
testandtest-wheeljobs inintel-ci.ymlnow need both build jobs,buildandbuild-wheel. Until now each one waited only for its own build job, so a failed wheel build still started the conda package tests, and a failed conda build still started the wheel tests.A failed build already fails the run, so no test runners start for a run that can't go green, and they stay free for other runs in the queue. On a green run the tests start once both sets of builds have finished.
Validation:
zizmorandpre-commitpass on the workflow. This pull request's own run exercises the green path; the failed-build path follows from howneedsworks and was not run.