Log search records with IDs, position, FRBR groups by JPrevost · Pull Request #481 · MITLibraries/timdex-ui

JPrevost · 2026-10-30T14:43:30Z

https://mitlibraries.atlassian.net/browse/TIMX-730

Developer

Accessibility

ANDI or WAVE has been run in accordance to our guide.
This PR contains no changes to the view layer.
New issues flagged by ANDI or WAVE have been resolved.
New issues flagged by ANDI or WAVE have been ticketed (link in the Pull Request details above).
No new accessibility issues have been flagged.

New ENV

All new ENV is documented in README.
All new ENV has been added to Heroku Pipeline, Staging and Prod.
ENV has not changed.

Approval beyond code review

UXWS/stakeholder approval has been confirmed.
UXWS/stakeholder review will be completed retroactively.
UXWS/stakeholder review is not needed.

Additional context needed to review

E.g., if the PR includes updated dependencies and/or data
migration, or how to confirm the feature is working.

Code Reviewer

Code

I have confirmed that the code works as intended.
Any CodeClimate issues have been fixed or confirmed as
added technical debt.

Documentation

The commit message is clear and follows our guidelines
(not just this pull request message).
The documentation has been updated or is unnecessary.
New dependencies are appropriate or there were no changes.

Testing

There are appropriate tests covering any new functionality.
No additional test coverage is required.

https://mitlibraries.atlassian.net/browse/TIMX-730

qltysh · 2026-10-30T14:45:06Z

❌ 12 blocking issues (13 total)

Tool	Category	Rule	Count
rubocop	Lint	Class has too many lines. [541/100]	3	❌
rubocop	Style	Align `\.filter\_map` with `\.send` on line 1208.	3	❌
rubocop	Lint	Assignment Branch Condition size for `load\_all\_results` is too high. [<26, 29, 3> 39.06/17]	2	❌
rubocop	Lint	Method has too many lines. [27/10]	2	❌
rubocop	Style	Incorrect formatting, autoformat by running `qlty fmt`.	1	❌
rubocop	Lint	Parenthesize the param `controller.send(:search_results_log_payload)[:returned_results]

                                       \.filter\_map \{ \|result\| result\[:frbr\_group\_id\] \}` to make sure that the block will be associated with the `controller\.send\(:search\_results\_log\_payload\)\[:returned\_results\]
                                       \.filter\_map` method call\.|1|❌|

|qlty|Structure|Function with high complexity (count = 5): search_results_log_returned_results|1||

@qltysh one-click actions:

Auto-fix formatting (qlty fmt && git push)

qltysh · 2026-10-30T14:45:08Z

+    return [] if search_log_http_error?
+
+    results = search_log_format.turbo_stream? ? Array(@append_results) : Array(@results)
+    search_results_log_entries(results)


Function with high complexity (count = 5): search_results_log_returned_results [qlty:function-complexity]

qltysh · 2026-10-30T14:45:08Z

+      controller.instance_variable_set(:@results, data[:results])

-      assert_equal ['12345'], controller.send(:search_results_log_payload)[:frbr_group_ids]
+      assert_equal ['12345'], controller.send(:search_results_log_payload)[:returned_results]


Parenthesize the param controller.send(:search_results_log_payload)[:returned_results] .filter_map { |result| result[:frbr_group_id] } to make sure that the block will be associated with the controller.send(:search_results_log_payload)[:returned_results] .filter_map method call. [rubocop:Lint/AmbiguousBlockAssociation]

qltysh · 2026-10-30T14:45:08Z


-      assert_equal ['12345'], controller.send(:search_results_log_payload)[:frbr_group_ids]
+      assert_equal ['12345'], controller.send(:search_results_log_payload)[:returned_results]
+                                           .filter_map { |result| result[:frbr_group_id] }


Align .filter_map with .send on line 1208. [rubocop:Layout/MultilineMethodCallIndentation]

qltysh · 2026-10-30T14:45:08Z


-        assert_equal ['merged-group'], controller.send(:search_results_log_payload)[:frbr_group_ids]
+        assert_equal ['merged-group'], controller.send(:search_results_log_payload)[:returned_results]
+                                                .pluck(:frbr_group_id)


Align .pluck with .send on line 1235. [rubocop:Layout/MultilineMethodCallIndentation]

qltysh · 2026-10-30T14:45:08Z

      assert_select '.record-title', text: /Cached Primo Document Title/
-      assert_equal ['cached-group'], @controller.send(:search_results_log_payload)[:frbr_group_ids]
+      assert_equal ['cached-group'], @controller.send(:search_results_log_payload)[:returned_results]
+                                               .pluck(:frbr_group_id)


Align .pluck with .send on line 1265. [rubocop:Layout/MultilineMethodCallIndentation]

coveralls · 2026-10-30T14:45:24Z

Coverage Report for CI Build 41075779929

Coverage increased (+0.003%) to 98.426%

Details

Coverage increased (+0.003%) from the base build.
Patch coverage: 39 of 39 lines across 3 files are fully covered (100%).
No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.

Coverage Stats


Relevant Lines:	1906
Covered Lines:	1876
Line Coverage:	98.43%
Coverage Strength:	1855.93 hits per line

💛 - Coveralls

Log search records with IDs, position, FRBR groups

de64162

https://mitlibraries.atlassian.net/browse/TIMX-730

qltysh Bot reviewed Oct 30, 2026

View reviewed changes

mitlib temporarily deployed to timdex-ui-pi-timx730-c53vt5txf October 30, 2026 14:47 Inactive

Log merge algorithm

ce00377

JPrevost deployed to timdex-ui-pi-timx730-c53vt5txf October 30, 2026 14:54

View deployment

Navigation Menu

Repository navigation

Log search records with IDs, position, FRBR groups - #481

Log search records with IDs, position, FRBR groups#481
JPrevost wants to merge 2 commits into
mainfrom
timx730

JPrevost commented Oct 30, 2026

Uh oh!

qltysh Bot commented Oct 30, 2026 •

edited

Loading

Uh oh!

qltysh Bot Oct 30, 2026

Uh oh!

qltysh Bot Oct 30, 2026

Uh oh!

qltysh Bot Oct 30, 2026

Uh oh!

qltysh Bot Oct 30, 2026

Uh oh!

qltysh Bot Oct 30, 2026

Uh oh!

coveralls commented Oct 30, 2026 •

edited

Loading

Uh oh!

This branch was successfully deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

JPrevost commented Oct 30, 2026

Developer

Accessibility

New ENV

Approval beyond code review

Additional context needed to review

Code Reviewer

Code

Documentation

Testing

Uh oh!

qltysh Bot commented Oct 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ 12 blocking issues (13 total)

Uh oh!

qltysh Bot Oct 30, 2026

Choose a reason for hiding this comment

Uh oh!

qltysh Bot Oct 30, 2026

Choose a reason for hiding this comment

Uh oh!

qltysh Bot Oct 30, 2026

Choose a reason for hiding this comment

Uh oh!

qltysh Bot Oct 30, 2026

Choose a reason for hiding this comment

Uh oh!

qltysh Bot Oct 30, 2026

Choose a reason for hiding this comment

Uh oh!

coveralls commented Oct 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report for CI Build 41075779929

Coverage increased (+0.003%) to 98.426%

Details

Uncovered Changes

Coverage Regressions

Coverage Stats

💛 - Coveralls

Uh oh!

This branch was successfully deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

qltysh Bot commented Oct 30, 2026 •

edited

Loading

coveralls commented Oct 30, 2026 •

edited

Loading