Repository navigation
Document culture-invariant color strings from CommunityToolkit.Maui PR #2874 - #678
Draft
Brandon Minnick (TheCodeTraveler) wants to merge 5 commits into
Draft
Brandon Minnick (TheCodeTraveler) wants to merge 5 commits into
Brandon Minnick (TheCodeTraveler) wants to merge 5 commits into
Conversation
…874) ToRgbaString, ToCmykString, ToCmykaString, ToHslString and ToHslaString now return the documented format when no culture or null is passed, and for InvariantCulture. The five color-string converters keep the binding behavior (ConverterCulture, else CurrentUICulture). Add the behavior-change note versus v17.0.0 to the extensions page and the culture section of each converter page. Fix the HSLA example, the Colors.Red hue (360), the RGBA format name and the extension usings in the touched sections. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The note said bindings are unchanged, but an invariant binding culture now writes 100% instead of 100 % on the CMYK, CMYKA, HSL and HSLA pages. Also fix a dangling modifier and name the color in two examples. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The behavior-change note omitted that InvariantCulture now returns 100% instead of 100 %, and its CurrentCulture advice failed for an invariant current culture. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The page mixed CommunityToolkit.Maui.Core.Extensions with CommunityToolkit.Maui.Extensions.Core, which does not exist. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
It derives from BaseConverter and converts RGBA strings back to colors. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
5 of 6 tasks
Contributor
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
Contributor
|
Learn Build status updates of commit 96fb417: ✅ Validation status: passed
For more details, please refer to the build report. |
Brandon Minnick (TheCodeTraveler)
left a comment
Contributor
Author
There was a problem hiding this comment.
Approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR coincides with the work done in CommunityToolkit.Maui PR CommunityToolkit/Maui#2874.
CommunityToolkit/Maui#2874 (fixes CommunityToolkit/Maui#2873) makes color strings culture-invariant when no culture is passed. This PR documents it:
null,InvariantCulture, and other cultures. Examples show the exact output of each case, plus a breaking-change note versus v17.0.0.ConverterCulture, elseCurrentUICulture. They show how to get the documented format withConverterCulture=InvariantCulture, and carry the same behavior-change note.CommunityToolkit.Maui.Core.Extensions.Colors.Redis360.ColorToRgbaStringConvertertwo-way.This stays a draft until the CommunityToolkit.Maui release that ships #2874 is published.
🤖 Generated with Claude Code