Repository navigation
Return of the Broken Villager #438
Description
Minecraft version: 1.12.2
Forge version: 14.23.5.2836
Base Metal version: 1.12-2.5.0-rc1.322
Issue:
Blacksmith Villagers are filled with many blank trades. It does not matter if the Villager Trades config is set to true or false. I do have several materials disabled if that matters.
Suggested fix:
I would suggest either get the config working or remove this feature from live version till the issue can be more completely fixed. I noticed this issue has been reported and fixed several times.
Activity
dshadowwolf commentedon Apr 30, 2019
damn, another f*cking broken config on top of everything else. The "config is not disabling" is likely fixed in -dev already - let me see if I can ping the person that understands that code... @jriwanek we've got another bug in VillagerTrades!
SkyBlade1978 commentedon Sep 29, 2026
@dshadowwolf this is an MMDLib bug so I don't really want to touch it in this round of base metals fixes, but these are the details if you wanna fix MMDLib, there are three related faults:
MMDLib’s trade builder uses an inverted condition:
filter(name -> !material.hasItem(name))
It therefore creates trades specifically for missing item forms, producing blank output slots (see VillagerTrades line 175).
The MMDLib Enable Villager Trades setting is read, but MMDLib registers its trades unconditionally, which explains why changing the setting did nothing.
Base Metals contains a guarded trade entry point in VillagerTrades line 28, added by the earlier optional-trades but that entry point stopped being called after the MMDLib split.
Consequently, intended Base Metals-specific trades are also not being registered properly.