Skip to content

Limit CurseForge uploads to one attempt #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SkyBlade1978 merged 1 commit into from
Oct 27, 2026
Merged

Limit CurseForge uploads to one attempt #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/deploy-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -532,6 +532,8 @@ jobs:
with:
curseforge-token: ${{ secrets.CURSEFORGE_TOKEN }}
curseforge-id: ${{ needs.preflight.outputs.curseforge_project_id }}
# A timeout or HTTP 500 can follow an accepted upload. Check the file before retrying.
curseforge-retry-attempts: 1
name: Sky's Building Pieces ${{ needs.preflight.outputs.release_version }} for Minecraft ${{ needs.preflight.outputs.minecraft_version }} (${{ needs.preflight.outputs.loader_display }})
version: ${{ needs.preflight.outputs.release_version }}
version-type: ${{ inputs.curseforge_release_level }}
Expand Down
9 changes: 6 additions & 3 deletions docs/RELEASING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,12 @@ use the same version suffix and branch naming rules. Each port must supply its
own tested build setup and correct metadata.

If publication stops, inspect the completed stages before retrying. Keep the
same commit and immutable bundle; rerun only failed jobs when an upload has
already succeeded. Do not create another CurseForge file while one is awaiting
approval.
same commit and immutable bundle. CurseForge uploads make one attempt: a
timeout or HTTP 500 can happen after the service has accepted the file.
Check the project's Files page, filename and hash before deciding what to run
again. If the file exists or is awaiting approval, leave the upload alone and
continue only the remaining publication steps. Never blindly rerun the
CurseForge job or create another file to resolve an uncertain response.

Content mods must be released before add-ons that require them. Keep dependency
source pins up to date when preparing a coordinated release.
Loading